HDFS-16619. Fix HttpHeaders.Values And HttpHeaders.Names Deprecated Import#4406
HDFS-16619. Fix HttpHeaders.Values And HttpHeaders.Names Deprecated Import#4406jojochuang merged 18 commits intoapache:trunkfrom
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@ayushtkn Please help me to review the code, I hope to replace the deprecated import with the recommended . |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@ayushtkn Can you help review the code? Thank you very much! |
| HttpURLConnection conn = getConn(cluster); | ||
| String xfoHeader = conn.getHeaderField("X-FRAME-OPTIONS"); | ||
| Assert.assertTrue("unexpected X-FRAME-OPTION in header", xfoHeader == null); | ||
| Assert.assertNull(xfoHeader); |
There was a problem hiding this comment.
| Assert.assertNull(xfoHeader); | |
| Assert.assertNull("unexpected X-FRAME-OPTION in header", xfoHeader); |
There was a problem hiding this comment.
@jojochuang Thank you very much for helping to review the code, I will modify the code!
| 86400000, 86400000, 86400000, 86400000, namesystem); | ||
| dtSecretManager.startThreads(); | ||
| Token<DelegationTokenIdentifier> token1 = new Token<DelegationTokenIdentifier>( | ||
| Token<DelegationTokenIdentifier> token1 = new Token<>( |
|
@jojochuang Thank you very much for helping to review the code, please help to review the code again. |
jojochuang
left a comment
There was a problem hiding this comment.
+1
Looks like the new variables are added in Netty 4.1. Downstream applications depending on Netty 4.0 could break. Not sure. So I'll only merge the change into Hadoop 3.4.0 (trunk) to avoid breakage.
|
@jojochuang Thank you very much! |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
…mport (apache#4406) Co-authored-by: slfan1989 <louj1988@@>
JIRA: HDFS-16619. Fix HttpHeaders.Values And HttpHeaders.Names Deprecated Import.
HttpHeaders.Values and HttpHeaders.Names are deprecated, use HttpHeaderValues and HttpHeaderNames instead.
HttpHeaders.Names
Deprecated.
Use HttpHeaderNames instead. Standard HTTP header names.
HttpHeaders.Values
Deprecated.
Use HttpHeaderValues instead. Standard HTTP header values.