HDFS-16610. Make fsck read timeout configurable#4384
Merged
sodonnel merged 2 commits intoapache:trunkfrom Jun 1, 2022
Merged
Conversation
ayushtkn
reviewed
May 31, 2022
Comment on lines
276
to
282
Member
There was a problem hiding this comment.
do you want to restrict the config to ms? Can keep only dfs.client.fsck.connect.timeout similar to dfs.webhdfs.socket.connect-timeout and allow timeunits?
Contributor
Author
There was a problem hiding this comment.
This suggestion makes sense. I have changed it to use the same technique as with webhdfs.
ayushtkn
approved these changes
May 31, 2022
Member
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
+1, if the build has no complains...
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
The native client is failing to build, but I cannot see how this change could cause that. I wonder if there is something else going on, or some other change has broken the build recently? |
Member
|
May be due to HDFS-16604, try to run the build again... |
Contributor
Author
|
I rebased against the latest trunk and force pushed it. Lets see if we get a better build this time. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
Good build this time, so I will commit. Thanks all for the reviews. |
asfgit
pushed a commit
that referenced
this pull request
Jun 1, 2022
(cherry picked from commit 34a973a) Conflicts: hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
In a cluster with a lot of small files, we encountered a case where fsck was very slow. I believe it is due to contention with many other threads reading / writing data on the cluster.
Sometimes fsck does not report any progress for more than 60 seconds and the client times out. Currently the connect and read timeout are hardcoded to 60 seconds. This change is to make them configurable.
How was this patch tested?
Tested manually by inserting a sleep into the fsck logic in the NN. I then adjusted the read timeout to validate I got a timeout or not depending on the timeout setting.