HDFS-16599. Fix typo in hadoop-hdfs-rbf module#4368
Merged
ayushtkn merged 8 commits intoapache:trunkfrom May 30, 2022
Merged
Conversation
ayushtkn
reviewed
May 28, 2022
Member
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
Can you take care of all Typos in the module or atleast at the class level, chasing one-one shall be tough and too much noise for the git.
one more example is L447: ClientProtocol, L1030,L1452
Contributor
Author
Hi, @ayushtkn Thanks for your suggestion, I will fix it. |
slfan1989
changed the title
ayushtkn
reviewed
May 28, 2022
Member
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
Have marked two changes, which aren't needed. Rest all LGTM
| * @param retryCount Current retry times | ||
| * @param method Method to invoke | ||
| * @param obj Target object for the method | ||
| * @param obj Target Object for the method |
Contributor
Author
There was a problem hiding this comment.
OK, I will fix it.
| * @param clazz Class for the return type. | ||
| * @return The result of invoking the method. | ||
| * @throws IOException If the invoke generated an error. | ||
| * @throws IOException If to invoke generated an error. |
Member
There was a problem hiding this comment.
these the->to change isn't correct. Remove all such
Contributor
Author
There was a problem hiding this comment.
OK, I will fix it.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
requested changes
May 28, 2022
Member
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
Dropped some comments, rest looks good
|
|
||
| /** | ||
| * Returns the number of paths to be processed by storage policy satisfier. | ||
| * Returns the number of paths to be processed by storage policy satisfies. |
Member
There was a problem hiding this comment.
SPS abbreviates to Storage Policy Satisfier. So this is correct only
|
|
||
| /** | ||
| * Get time between we receiving the operation and sending it to the Namenode. | ||
| * Get time between we're receiving the operation and sending it to the Namenode. |
| private int compareModDates(FederationNamenodeContext o1, | ||
| FederationNamenodeContext o2) { | ||
| // Reverse sort, lowest position is highest priority. | ||
| // Reverse sort, the lowest position is the highest priority. |
| * Clean the unused connections for this pool. | ||
| * | ||
| * @param pool Connection pool to cleanup. | ||
| * @param pool Connection pool to clean up. |
| return false; | ||
| } else { | ||
| // If old entry is not available, sync quota always, since we can't | ||
| // If old entry is not available, sync quota always, since we can |
Member
There was a problem hiding this comment.
changed meaning itself, revert
| mountTableRefresherService.init(config); | ||
| // One router is not responding for 1 minute, still refresh should | ||
| // finished in 5 second as cache update timeout is set 5 second. | ||
| // be finished in 5 second as cache update timeout is set 5 second. |
|
|
||
| // Create a test file on a single NN that is accessed via a getRouter() path | ||
| // with 2 destinations. All tests should failover to the alternate | ||
| // with 2 destinations. All tests should fail over to the alternate |
Member
There was a problem hiding this comment.
revert, failover is a well accepted word for us
| cluster.waitNamenodeRegistration(); | ||
|
|
||
| // Setup the mount table | ||
| // Set up the mount table |
| // 2) ns0:nn0 - Active (oldest) | ||
| // 3) ns0:nn0 - Active (2nd oldest) | ||
| // 4) ns0:nn0 - Active (3nd oldest element, newest active element) | ||
| // 4) ns0:nn0 - Active (3nd the oldest element, the newest active element) |
Member
There was a problem hiding this comment.
Change
3nd -> 3rd,
no need of first the
| assertTrue(namenodeHeartbeat(report)); | ||
|
|
||
| // standby - newest overall | ||
| // standby - the newest overall |
Contributor
Author
|
@ayushtkn Thanks a lot for your suggestion, I've done the fix. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
ayushtkn
approved these changes
May 29, 2022
Member
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
LGTM.
If no further comments, will commit by tomorrow EOD
Contributor
Author
|
@ayushtkn Thank you very much for your help reviewing the code! |
ayushtkn
changed the title
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…uted by fanshilun. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA:HDFS-16599. Fix typo in RouterRpcClient.