HDFS-16595. Slow peer metrics - add median, median absolute deviation and upper latency limits#4357
Merged
jojochuang merged 1 commit intoapache:trunkfrom Jun 3, 2022
Merged
Conversation
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@tomscut @jojochuang @saintstack Could you please review this PR? The QA failures with |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
virajjasani
changed the title
tomscut
reviewed
May 28, 2022
Contributor
tomscut
left a comment
tomscut
left a comment
There was a problem hiding this comment.
The whole thing looks good to me. I have two quick questions:
- Is there any further work after adding these metrics? Where are these metrics going to be used?
- We changed the JSON structure of
slowpeer, which may be an incompatible change. We need add some releaseNote.
Contributor
There was a problem hiding this comment.
Can we do not define a new variable outlierMetrics1 here, just to make it a little bit cleaner.
Contributor
Author
There was a problem hiding this comment.
Sorry I didn't get it. It's already outlierMetrics1 :)
Contributor
There was a problem hiding this comment.
I mean just write it like this:
tracker.addReport("node2", "node1", new OutlierMetrics(0.0, 0.0, 0.0, 1.2));
Contributor
Author
There was a problem hiding this comment.
Got it, addressed this change in the latest commit, thanks @tomscut
virajjasani
commented
May 28, 2022
Contributor
Author
virajjasani
left a comment
virajjasani
left a comment
There was a problem hiding this comment.
Is there any further work after adding these metrics? Where are these metrics going to be used?
I believe this is it, we don't seem to have any further addition to the metrics for slow latency measurements. These metrics are for operators to get better insights, e.g. if upper latency limit changes over time, some datanodes might be reported slow but they might actually not be slow. Whereas if upper bound doesn't change much and there is significant difference b/ reported latency of a datanode vs upper limit, then operator should immediately take actions.
We changed the JSON structure of slowpeer, which may be an incompatible change. We need add some releaseNote.
Sure let me add release node once the PR is merged, does it sound good?
Thanks @tomscut for the reviews!
Contributor
Author
There was a problem hiding this comment.
Sorry I didn't get it. It's already outlierMetrics1 :)
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
tomscut
approved these changes
May 30, 2022
Contributor
tomscut
left a comment
tomscut
left a comment
There was a problem hiding this comment.
Looks good from my side.
Contributor
|
Hi @jojochuang , could you please also take a look. Thanks. |
jojochuang
reviewed
Jun 2, 2022
Contributor
There was a problem hiding this comment.
move .setMad to its own line?
Suggested change
| .setMedian(outlierMetrics.getMedian()).setMad(outlierMetrics.getMad()) | |
| .setMedian(outlierMetrics.getMedian()) | |
| .setMad(outlierMetrics.getMad()) |
Contributor
Author
There was a problem hiding this comment.
Done, thanks for the suggestion.
virajjasani
force-pushed
the
HDFS-16595-trunk
branch
from
64a1805 to
e94f367
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
Test failures in |
virajjasani
added a commit
to virajjasani/hadoop
that referenced
this pull request
Jun 5, 2022
…its (apache#4357) Reviewed-by: Tao Li <tomscut@apache.org> Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…its (apache#4357) Reviewed-by: Tao Li <tomscut@apache.org> Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Slow datanode metrics include slow node and it's reporting node details. With HDFS-16582, we added the aggregate latency that is perceived by the reporting nodes.
In order to get more insights into how the outlier slownode's latencies differ from the rest of the nodes, we should also expose median, median absolute deviation and the calculated upper latency limit details.
How was this patch tested?
UTs and Dev cluster testing:
For code changes: