Skip to content

HADOOP-18251. Fix failure of extracting JIRA id from commit message in git_jira_fix_version_check.py.#4344

Merged
iwasakims merged 1 commit intoapache:trunkfrom
iwasakims:HADOOP-18251
May 26, 2022
Merged

HADOOP-18251. Fix failure of extracting JIRA id from commit message in git_jira_fix_version_check.py.#4344
iwasakims merged 1 commit intoapache:trunkfrom
iwasakims:HADOOP-18251

Conversation

@iwasakims
Copy link
Member

@iwasakims iwasakims commented May 23, 2022

https://issues.apache.org/jira/browse/HADOOP-18251

git_jira_fix_version_check.py is confused by commit message like "YARN-1151. Ability to configure auxiliary services from HDFS-based JAR files." which contains both YARN- and HDFS-. The latter HDFS- is unexpectedly picked as JIRA issue id then 404 is thrown on accessing invalid URL like "https://issues.apache.org/jira/rest/api/2/issue/HDFS-".

Traceback (most recent call last):
  File "/home/centos/srcs/hadoop/dev-support/git-jira-validation/git_jira_fix_version_check.py", line 87, in <module>
    issue = jira.issue(ACTUAL_PROJECT_JIRA + JIRA_NUM)
  File "/home/centos/venv/lib64/python3.6/site-packages/jira/client.py", line 1404, in issue
    issue.find(id, params=params)
  File "/home/centos/venv/lib64/python3.6/site-packages/jira/resources.py", line 288, in find
    self._load(url, params=params)
  File "/home/centos/venv/lib64/python3.6/site-packages/jira/resources.py", line 458, in _load
    r = self._session.get(url, headers=headers, params=params)
  File "/home/centos/venv/lib64/python3.6/site-packages/jira/resilientsession.py", line 195, in get
    return self.__verb("GET", str(url), **kwargs)
  File "/home/centos/venv/lib64/python3.6/site-packages/jira/resilientsession.py", line 189, in __verb
    raise_on_error(response, verb=verb, **kwargs)
  File "/home/centos/venv/lib64/python3.6/site-packages/jira/resilientsession.py", line 70, in raise_on_error
    **kwargs,
jira.exceptions.JIRAError: JiraError HTTP 404 url: https://issues.apache.org/jira/rest/api/2/issue/HDFS-
        text: Issue Does Not Exist

If commit message contains multiple match on 'HADOOP-|HDFS-|YARN-|MAPREDUCE-', choosing the first one should be the fix.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 40s Maven dependency ordering for branch
+1 💚 shadedclient 21m 31s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 32s Maven dependency ordering for patch
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 pylint 0m 6s No new issues.
+1 💚 shadedclient 19m 11s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 50s The patch does not generate ASF License warnings.
59m 21s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4344/1/artifact/out/Dockerfile
GITHUB PR #4344
Optional Tests dupname asflicense codespell pylint
uname Linux 4a6979d8ec56 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 5bcb6bd
Max. process+thread count 543 (vs. ulimit of 5500)
modules C: U:
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4344/1/console
versions git=2.25.1 maven=3.6.3 pylint=2.6.0
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@dannycjones dannycjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (non-binding)

@hotcodemacha
Copy link
Contributor

+1 (non-binding)

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a python expert. but the logic makes sense to me.
I am pretty sure @iwasakims would have given it a try as well and it does work :-)

LGTM

@iwasakims
Copy link
Member Author

Thanks, all. I'm merging this.

@iwasakims iwasakims merged commit 6b331dd into apache:trunk May 26, 2022
iwasakims added a commit that referenced this pull request May 26, 2022
…n git_jira_fix_version_check.py. (#4344)

(cherry picked from commit 6b331dd)
iwasakims added a commit that referenced this pull request May 26, 2022
…n git_jira_fix_version_check.py. (#4344)

(cherry picked from commit 6b331dd)
iwasakims added a commit that referenced this pull request May 26, 2022
…n git_jira_fix_version_check.py. (#4344)

(cherry picked from commit 6b331dd)
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants