HADOOP-18251. Fix failure of extracting JIRA id from commit message in git_jira_fix_version_check.py.#4344
Merged
iwasakims merged 1 commit intoapache:trunkfrom May 26, 2022
Merged
Conversation
…n git_jira_fix_version_check.py.
|
🎊 +1 overall
This message was automatically generated. |
hotcodemacha
approved these changes
May 25, 2022
Contributor
|
+1 (non-binding) |
ayushtkn
approved these changes
May 25, 2022
Member
ayushtkn
left a comment
There was a problem hiding this comment.
Not a python expert. but the logic makes sense to me.
I am pretty sure @iwasakims would have given it a try as well and it does work :-)
LGTM
Member
Author
|
Thanks, all. I'm merging this. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…n git_jira_fix_version_check.py. (apache#4344)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HADOOP-18251
git_jira_fix_version_check.py is confused by commit message like
"YARN-1151. Ability to configure auxiliary services from HDFS-based JAR files."which contains bothYARN-andHDFS-. The latterHDFS-is unexpectedly picked as JIRA issue id then 404 is thrown on accessing invalid URL like "https://issues.apache.org/jira/rest/api/2/issue/HDFS-".If commit message contains multiple match on 'HADOOP-|HDFS-|YARN-|MAPREDUCE-', choosing the first one should be the fix.