YARN-10487. Support getQueueUserAcls, listReservations, getApplicationAttempts, getContainerReport, getContainers, getResourceTypeInfo API's for Federation#4341
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
...outer/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/RouterYarnClientUtils.java
Show resolved
Hide resolved
...oop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/RouterMetrics.java
Show resolved
Hide resolved
| ApplicationId appId = | ||
| ApplicationId.newInstance(System.currentTimeMillis(), 1); | ||
| ApplicationAttemptId appAttemptId = | ||
| ApplicationAttemptId.newInstance(appId, 1); |
There was a problem hiding this comment.
ApplicationAttemptId needs to be queried in yarn and cannot be generated directly.
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
| </property> | ||
|
|
||
| <property> | ||
| <name>yarn.scheduler.capacity.root.default.reservable</name> |
There was a problem hiding this comment.
Hi, @goiri , testListReservations junit test needs the queue to be reservable, I set root.default reservable = true.
There was a problem hiding this comment.
I newly set the root.decided queue for Junit Test.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
…sh testGetResourceTypeInfoRequest.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Hi, @goiri please help me to review the code, thank you very much! |
...-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/resources/capacity-scheduler.xml
Show resolved
Hide resolved
|
@goiri Please help me to review the code again, thank you very much! I very much hope to continue to improve the capabilities of YARN Federation. I will continue to follow up the development related to YARN-11159. |
|
@goiri Thank you very much for helping to review the code. Can you help me merge this PR to the trunk branch? |
…nAttempts, getContainerReport, getContainers, getResourceTypeInfo API's for Federation (apache#4341)
JIRA: YARN-10487. Support getQueueUserAcls, listReservations, getApplicationAttempts, getContainerReport, getContainers, getResourceTypeInfo API's for Federation.
There are 6 methods that pr needs to implement this time.
Step 1, I need to improve the log message first(#4336)
Step 2, This method has the following points that need to be improved
org.apache.hadoop.yarn.server.router.clientrm.FederationClientInterceptor.java#getApplicationAttemptReport
Step3, Junit Test occasionally reports errors as follows: