HDFS-16587. Allow configuring the number of JournalNodeRPCServer Hand…#4339
Merged
ayushtkn merged 1 commit intoapache:trunkfrom May 28, 2022
Merged
HDFS-16587. Allow configuring the number of JournalNodeRPCServer Hand…#4339ayushtkn merged 1 commit intoapache:trunkfrom
ayushtkn merged 1 commit intoapache:trunkfrom
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
requested changes
May 25, 2022
Member
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
makes sense to me.
Please extend a test as well, if not direct can grep the log outputs & validate that only....
Comment on lines
94
to
96
Member
There was a problem hiding this comment.
Add some validation here for a valid value range, as in shouldn't be negative or so.
If it is an invalid entry, Add a warn log and use the default value.
Post that have a INFO log telling about the handler count...
Contributor
Author
There was a problem hiding this comment.
@ayushtkn Thanks for your comment, it helped me a lot. And the patch has been updated, please help me review it again. Thanks
|
🎊 +1 overall
This message was automatically generated. |
ayushtkn
reviewed
May 26, 2022
Member
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
Dropped minor comments, Jenkins has some checkstyle warnings as well. give a check.
Apart changes LGTM
Member
There was a problem hiding this comment.
Assert. isn't required there is already a static import in the class.
Same for all the other statements
Member
There was a problem hiding this comment.
can you change the variable name to handlerCount and the method to getHandlerCount()
Comment on lines
98
to
102
Member
There was a problem hiding this comment.
Change to
LOG.warn("Invalid value for: {} = {}, Should be > 0,"
+ " will use default value of: {}.",
DFS_JOURNALNODE_HANDLER_COUNT_KEY, confHandler,
DFS_JOURNALNODE_HANDLER_COUNT_DEFAULT);
Contributor
Author
|
Thanks @ayushtkn. The patch has been updated, please help me review it again. Thanks |
ayushtkn
approved these changes
May 27, 2022
|
💔 -1 overall
This message was automatically generated. |
Member
|
Seems some test failures, can you give a check |
Contributor
Author
|
checking, If the failed UTs is not related to the modification and will create a new PR to fix the failed UTs. |
Contributor
Author
@ayushtkn please help me review again. |
Member
|
Merged. Thanx @ZanderXu for the contribution!!! |
Contributor
Author
|
Thanks @ayushtkn for your review. I will contribute some bugs and improvements encountered in our production to the trunk, and I will need your help to review them later. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…lers (apache#4339). Contributed by ZanderXu. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the number of JournalNodeRpc Handlers is hard-code 5, we need to support this parameter configurable.