Skip to content

HDFS-16586. Purge FsDatasetAsyncDiskService threadgroup; it causes BP… #4338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saintstack merged 2 commits into from
May 23, 2022
Merged

HDFS-16586. Purge FsDatasetAsyncDiskService threadgroup; it causes BP… #4338

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd5ba66
HDFS-16586. Purge FsDatasetAsyncDiskService threadgroup; it causes BP…
saintstack May 20, 2022
4593ac0
Non-change to trip another unit test run
saintstack May 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetAsyncDiskService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ class FsDatasetAsyncDiskService {

private final DataNode datanode;
private final FsDatasetImpl fsdatasetImpl;
private final ThreadGroup threadGroup;
private Map<String, ThreadPoolExecutor> executors
= new HashMap<String, ThreadPoolExecutor>();
private Map<String, Set<Long>> deletedBlockIds
Expand All @@ -91,7 +90,6 @@ class FsDatasetAsyncDiskService {
FsDatasetAsyncDiskService(DataNode datanode, FsDatasetImpl fsdatasetImpl) {
this.datanode = datanode;
this.fsdatasetImpl = fsdatasetImpl;
this.threadGroup = new ThreadGroup(getClass().getSimpleName());
maxNumThreadsPerVolume = datanode.getConf().getInt(
DFSConfigKeys.DFS_DATANODE_FSDATASETASYNCDISK_MAX_THREADS_PER_VOLUME_KEY,
DFSConfigKeys.DFS_DATANODE_FSDATASETASYNCDISK_MAX_THREADS_PER_VOLUME_DEFAULT);
Expand All @@ -110,7 +108,7 @@ public Thread newThread(Runnable r) {
synchronized (this) {
thisIndex = counter++;
}
Thread t = new Thread(threadGroup, r);
Thread t = new Thread(r);
t.setName("Async disk worker #" + thisIndex +
" for volume " + volume);
return t;
Expand Down