Skip to content

HDFS-16585.Add @VisibleForTesting in Dispatcher.java #4337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jojochuang merged 1 commit into from
May 26, 2022
Merged

HDFS-16585.Add @VisibleForTesting in Dispatcher.java #4337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ public class PendingMove {
private DDatanode proxySource;
private StorageGroup target;

@VisibleForTesting
PendingMove(Source source, StorageGroup target) {
this.source = source;
this.target = target;
Expand Down Expand Up @@ -282,6 +283,7 @@ private boolean chooseBlockAndProxy() {
/**
* @return true if the given block is good for the tentative move.
*/
@VisibleForTesting
boolean markMovedIfGoodBlock(DBlock block, StorageType targetStorageType) {
synchronized (block) {
synchronized (movedBlocks) {
Expand Down Expand Up @@ -1361,6 +1363,7 @@ public static boolean checkForSuccess(
* 2. the block does not have a replica/internalBlock on the target;
* 3. doing the move does not reduce the number of racks that the block has
*/
@VisibleForTesting
boolean isGoodBlockCandidate(StorageGroup source, StorageGroup target,
StorageType targetStorageType, DBlock block) {
if (source.equals(target)) {
Expand Down