You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the PR(#4267) of HADOOP-18224. Upgrade maven compiler plugin to 3.10.1, I found that hadoop-common has a lot of javadoc compilation errors. I fixed it on the trunk, hoping to backport these changes to branch 3.3. These changes will ensure that javadoc will pass in JDK11 compilation.
Hi, @steveloughran, I have fixed the java-doc of the hadoop-common module of branch-3.3, please help to review the code, I will continue to fix the java doc of other modules, I hope to get your support.
+1 (non-binding), the backport changes look good, and Jenkins QA results are also good.
Thank you @slfan1989 for your work here. @steveloughran / @aajisaka could help review/merge the PR.
@slfan1989 can you link the original trunk jira as well in your jira, can you point out what all has changed from trunk to this PR, if there is anything major there....
@slfan1989 can you link the original trunk jira as well in your jira, can you point out what all has changed from trunk to this PR, if there is anything major there....
In the PR(#4267) of HADOOP-18224. Upgrade maven compiler plugin to 3.10.1, I found that hadoop-common has a lot of javadoc compilation errors. I fixed it on the trunk(#4292), hoping to backport these changes to branch 3.3. These changes will ensure that hadoop common moudle javadoc will pass in JDK11 compilation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA : HADOOP-18244. Fix Hadoop-Common JavaDoc Error on branch-3.3
For code changes:
In the PR(#4267) of HADOOP-18224. Upgrade maven compiler plugin to 3.10.1, I found that hadoop-common has a lot of javadoc compilation errors. I fixed it on the trunk, hoping to backport these changes to branch 3.3. These changes will ensure that javadoc will pass in JDK11 compilation.