YARN-10465. Support getNodeToLabels, getLabelsToNodes, getClusterNodeLabels API's for Federation#4317
Merged
goiri merged 13 commits intoapache:trunkfrom May 20, 2022
Merged
Conversation
added 6 commits
May 16, 2022 14:56
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
slfan1989
changed the title
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
Hi, @goiri , YARN-10465:Support getNodeToLabels, getLabelsToNodes, getClusterNodeLabels API's for Federation, It has been done in this pr, please help to review the code, thank you very much! |
goiri
reviewed
May 17, 2022
Member
There was a problem hiding this comment.
ApplicationClientProtocol client inside the try
Member
There was a problem hiding this comment.
It looks like we do this pattern a bunch of time.
Maybe we can generalizer this with some lambda passed as a parameter?
Contributor
Author
There was a problem hiding this comment.
Is it possible to design a generic function like this?
private <R> Collection<R> invokeAppClientProtocolMethod(
Boolean filterInactiveSubClusters, ClientMethod request, Class<R> clazz)
throws YarnException, RuntimeException {
Map<SubClusterId, SubClusterInfo> subClusters =
federationFacade.getSubClusters(filterInactiveSubClusters);
return subClusters.keySet().stream().map(subClusterId -> {
try {
ApplicationClientProtocol protocol =
getClientRMProxyForSubCluster(subClusterId);
Method method = ApplicationClientProtocol.class
.getMethod(request.getMethodName(), request.getTypes());
return clazz.cast(method.invoke(protocol, request.getParams()));
} catch (YarnException | NoSuchMethodException | IllegalAccessException |
InvocationTargetException ex) {
throw new RuntimeException(ex);
}
}).collect(Collectors.toList());
}
...outer/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/RouterYarnClientUtils.java
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
Hi, @goiri please help to review the code again,thank you very much! |
goiri
approved these changes
May 18, 2022
Contributor
Author
|
Hi, @goiri ,Thanks for your help reviewing the code, Can you help with merging into the trunk branch? |
goiri
approved these changes
May 18, 2022
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…Labels API's for Federation (apache#4317)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: https://issues.apache.org/jira/browse/YARN-10465
getNodeToLabels, getLabelsToNodes, getClusterNodeLabels API's are not implemented under the Yarn Federation framework, implement the methods.
How was this patch tested?
Added Junit Test to test normal requests and NULL requests, all as expected
For code changes:
1.Use the loop method to call the getNodeToLabels, getLabelsToNodes, getClusterNodeLabels method of the subcluster one by one
2.Complete the Metric indicator counting function