YARN-11128. Fix comments in TestProportionalCapacityPreemptionPolicy* by hotcodemacha · Pull Request #4271 · apache/hadoop

hotcodemacha · 2022-05-06T14:47:40Z

Description of PR

Fix comments in TestProportionalCapacityPreemptionPolicy*

JIRA: YARN-11128

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?

hadoop-yetus · 2022-05-06T18:36:35Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	20m 11s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 32s		trunk passed
+1 💚	compile	1m 17s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	1m 8s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 4s		trunk passed
+1 💚	mvnsite	1m 13s		trunk passed
+1 💚	javadoc	1m 7s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	0m 53s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	2m 21s		trunk passed
+1 💚	shadedclient	24m 43s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 56s		the patch passed
+1 💚	compile	1m 4s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	1m 4s		the patch passed
+1 💚	compile	0m 55s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 55s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 45s		the patch passed
+1 💚	mvnsite	0m 57s		the patch passed
+1 💚	javadoc	0m 45s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	0m 41s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	2m 7s		the patch passed
+1 💚	shadedclient	23m 58s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	100m 17s	/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt	hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚	asflicense	0m 42s		The patch does not generate ASF License warnings.
		227m 36s

Reason	Tests
Failed junit tests	hadoop.yarn.server.resourcemanager.metrics.TestSystemMetricsPublisher
	hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokenAuthentication
	hadoop.yarn.webapp.TestRMWithXFSFilter
	hadoop.yarn.server.resourcemanager.metrics.TestCombinedSystemMetricsPublisher
	hadoop.yarn.server.resourcemanager.TestRMHA
	hadoop.yarn.server.resourcemanager.TestClientRMService
	hadoop.yarn.server.resourcemanager.webapp.TestRMWebappAuthentication

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4271/1/artifact/out/Dockerfile
GITHUB PR	#4271
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 4b2df7627c81 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `bc9f1ec`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4271/1/testReport/
Max. process+thread count	896 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4271/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hotcodemacha · 2022-05-07T22:43:42Z

@aajisaka - Can you please have a look at this?

Thanks

aajisaka

Would you address the comment for user? I'm +1 if that is addressed.

By the way, I noticed that the documented definition in MockApplication.java and MockContainer.java are missing or incomplete. We can fix them in a separate issue.

aajisaka · 2022-05-07T22:53:40Z

...ver/resourcemanager/monitor/capacity/TestProportionalCapacityPreemptionPolicyIntraQueue.java


    String appsConfig =
-    // queueName\t(priority,resource,host,expression,#repeat,reserved,pending)
+    // queueName\t(priority,resource,host,expression,#repeat,reserved,pending,user)


user is sometimes not set. Need to comment that user is optional.

hotcodemacha · 2022-05-08T02:24:27Z

Would you address the comment for user? I'm +1 if that is addressed.

By the way, I noticed that the documented definition in MockApplication.java and MockContainer.java are missing or incomplete. We can fix them in a separate issue.

Sure, I will create a separate JIRA for that. Thanks.

hadoop-yetus · 2022-05-08T05:50:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 53s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 47s		trunk passed
+1 💚	compile	1m 17s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	1m 7s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 2s		trunk passed
+1 💚	mvnsite	1m 13s		trunk passed
+1 💚	javadoc	1m 6s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	0m 55s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	2m 25s		trunk passed
+1 💚	shadedclient	24m 41s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 57s		the patch passed
+1 💚	compile	1m 4s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	1m 4s		the patch passed
+1 💚	compile	0m 55s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 55s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 45s		the patch passed
+1 💚	mvnsite	0m 59s		the patch passed
+1 💚	javadoc	0m 47s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	0m 42s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	2m 7s		the patch passed
+1 💚	shadedclient	24m 20s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	100m 2s	/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt	hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚	asflicense	0m 42s		The patch does not generate ASF License warnings.
		208m 54s

Reason	Tests
Failed junit tests	hadoop.yarn.server.resourcemanager.metrics.TestSystemMetricsPublisher
	hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokenAuthentication
	hadoop.yarn.webapp.TestRMWithXFSFilter
	hadoop.yarn.server.resourcemanager.metrics.TestCombinedSystemMetricsPublisher
	hadoop.yarn.server.resourcemanager.TestRMHA
	hadoop.yarn.server.resourcemanager.TestClientRMService
	hadoop.yarn.server.resourcemanager.webapp.TestRMWebappAuthentication

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4271/2/artifact/out/Dockerfile
GITHUB PR	#4271
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 23f23280bb22 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `c8c71e7`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4271/2/testReport/
Max. process+thread count	937 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4271/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hemanthboyina

+1

hemanthboyina

looks the build is triggered and immediately getting failed

hadoop-yetus · 2022-05-18T21:46:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	45m 13s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	40m 50s		trunk passed
+1 💚	compile	1m 9s		trunk passed
+1 💚	checkstyle	1m 4s		trunk passed
+1 💚	mvnsite	1m 16s		trunk passed
+1 💚	javadoc	1m 3s		trunk passed
+1 💚	spotbugs	2m 24s		trunk passed
+1 💚	shadedclient	23m 57s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 58s		the patch passed
+1 💚	compile	0m 56s		the patch passed
+1 💚	javac	0m 56s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 46s		the patch passed
+1 💚	mvnsite	1m 0s		the patch passed
+1 💚	javadoc	0m 43s		the patch passed
+1 💚	spotbugs	2m 9s		the patch passed
+1 💚	shadedclient	23m 51s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	102m 59s		hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚	asflicense	0m 42s		The patch does not generate ASF License warnings.
		249m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4271/3/artifact/out/Dockerfile
GITHUB PR	#4271
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux b6f66a039f76 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `c8c71e7`
Default Java	Red Hat, Inc.-1.8.0_332-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4271/3/testReport/
Max. process+thread count	935 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4271/3/console
versions	git=2.9.5 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-05-19T01:32:57Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	26m 24s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	25m 29s		trunk passed
+1 💚	compile	1m 22s		trunk passed
+1 💚	checkstyle	1m 11s		trunk passed
+1 💚	mvnsite	1m 27s		trunk passed
+1 💚	javadoc	1m 11s		trunk passed
+1 💚	spotbugs	2m 36s		trunk passed
+1 💚	shadedclient	24m 57s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 3s		the patch passed
+1 💚	compile	1m 2s		the patch passed
+1 💚	javac	1m 2s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 56s		the patch passed
+1 💚	mvnsite	1m 21s		the patch passed
+1 💚	javadoc	0m 50s		the patch passed
+1 💚	spotbugs	2m 54s		the patch passed
+1 💚	shadedclient	26m 43s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	108m 16s	/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt	hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚	asflicense	0m 48s		The patch does not generate ASF License warnings.
		226m 5s

Reason	Tests
Failed junit tests	hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4271/3/artifact/out/Dockerfile
GITHUB PR	#4271
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 11bf19992a0b 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `c8c71e7`
Default Java	Red Hat, Inc.-1.8.0_312-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4271/3/testReport/
Max. process+thread count	876 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4271/3/console
versions	git=2.27.0 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

aajisaka · 2022-05-26T06:52:15Z

Merged. Thank you @ashutoshcipher and @hemanthboyina

…#4271) Co-authored-by: Ashutosh Gupta <ashugpt@amazon.com> Reviewed-by: Hemanth Boyina <hemanthboyina@apache.org> Signed-off-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit e3e9369)

…apache#4271) Co-authored-by: Ashutosh Gupta <ashugpt@amazon.com> Reviewed-by: Hemanth Boyina <hemanthboyina@apache.org> Signed-off-by: Akira Ajisaka <aajisaka@apache.org>

Ashutosh Gupta added 2 commits May 6, 2022 15:41

YARN-11128. Fix comments in TestProportionalCapacityPreemptionPolicy*

6ed383f

changing prio to priority

bc9f1ec

aajisaka requested changes May 7, 2022

View reviewed changes

aajisaka changed the title Yarn 11128. Fix comments in TestProportionalCapacityPreemptionPolicy* YARN-11128. Fix comments in TestProportionalCapacityPreemptionPolicy* May 7, 2022

Commenting user is optional

c8c71e7

hotcodemacha requested a review from aajisaka May 10, 2022 11:06

hemanthboyina reviewed May 18, 2022

View reviewed changes

hotcodemacha requested a review from hemanthboyina May 18, 2022 22:50

aajisaka approved these changes May 25, 2022

View reviewed changes

aajisaka merged commit e3e9369 into apache:trunk May 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YARN-11128. Fix comments in TestProportionalCapacityPreemptionPolicy*#4271

YARN-11128. Fix comments in TestProportionalCapacityPreemptionPolicy*#4271
aajisaka merged 3 commits intoapache:trunkfrom
hotcodemacha:YARN-11128

hotcodemacha commented May 6, 2022 •

edited by aajisaka

Loading

Uh oh!

hadoop-yetus commented May 6, 2022

Uh oh!

hotcodemacha commented May 7, 2022

Uh oh!

aajisaka left a comment •

edited

Loading

Uh oh!

aajisaka May 7, 2022

Uh oh!

hotcodemacha May 8, 2022

Uh oh!

hotcodemacha commented May 8, 2022

Uh oh!

hadoop-yetus commented May 8, 2022

Uh oh!

hemanthboyina left a comment

Uh oh!

hemanthboyina left a comment

Uh oh!

hadoop-yetus commented May 18, 2022

Uh oh!

hadoop-yetus commented May 19, 2022

Uh oh!

aajisaka commented May 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

hotcodemacha commented May 6, 2022 • edited by aajisaka Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Uh oh!

hadoop-yetus commented May 6, 2022

Uh oh!

hotcodemacha commented May 7, 2022

Uh oh!

aajisaka left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aajisaka May 7, 2022

Choose a reason for hiding this comment

Uh oh!

hotcodemacha May 8, 2022

Choose a reason for hiding this comment

Uh oh!

hotcodemacha commented May 8, 2022

Uh oh!

hadoop-yetus commented May 8, 2022

Uh oh!

hemanthboyina left a comment

Choose a reason for hiding this comment

Uh oh!

hemanthboyina left a comment

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented May 18, 2022

Uh oh!

hadoop-yetus commented May 19, 2022

Uh oh!

aajisaka commented May 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hotcodemacha commented May 6, 2022 •

edited by aajisaka

Loading

aajisaka left a comment •

edited

Loading