Skip to content

HDFS-16525.System.err should be used when error occurs in multiple methods in DFSAdmin class #4122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ferhui merged 3 commits into from
May 12, 2022
Merged

HDFS-16525.System.err should be used when error occurs in multiple methods in DFSAdmin class #4122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19eddff
HDFS-16525
singer-bin Mar 30, 2022
7d7658d
empty commit
singer-bin May 11, 2022
01f9799
empty commit
singer-bin May 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,7 +882,7 @@ public int saveNamespace(String[] argv) throws IOException {
+ proxy.getAddress());
}
}catch (IOException ioe){
System.out.println("Save namespace failed for " +
System.err.println("Save namespace failed for " +
proxy.getAddress());
exceptions.add(ioe);
}
Expand Down Expand Up @@ -939,7 +939,7 @@ public int restoreFailedStorage(String arg) throws IOException {
System.out.println("restoreFailedStorage is set to " + res + " for "
+ proxy.getAddress());
} catch (IOException ioe){
System.out.println("restoreFailedStorage failed for "
System.err.println("restoreFailedStorage failed for "
+ proxy.getAddress());
exceptions.add(ioe);
}
Expand Down Expand Up @@ -982,7 +982,7 @@ public int refreshNodes() throws IOException {
System.out.println("Refresh nodes successful for " +
proxy.getAddress());
}catch (IOException ioe){
System.out.println("Refresh nodes failed for " +
System.err.println("Refresh nodes failed for " +
proxy.getAddress());
exceptions.add(ioe);
}
Expand Down Expand Up @@ -1038,7 +1038,7 @@ public int listOpenFiles(String[] argv) throws IOException {
openFilesRemoteIterator = dfs.listOpenFiles(openFilesTypes, path);
printOpenFiles(openFilesRemoteIterator);
} catch (IOException ioe){
System.out.println("List open files failed.");
System.err.println("List open files failed.");
throw ioe;
}
return 0;
Expand Down Expand Up @@ -1470,7 +1470,7 @@ public int finalizeUpgrade() throws IOException {
System.out.println("Finalize upgrade successful for " +
proxy.getAddress());
}catch (IOException ioe){
System.out.println("Finalize upgrade failed for " +
System.err.println("Finalize upgrade failed for " +
proxy.getAddress());
exceptions.add(ioe);
}
Expand Down Expand Up @@ -1599,7 +1599,7 @@ public int metaSave(String[] argv, int idx) throws IOException {
throw re;
}
} catch (IOException ioe) {
System.out.println("Created metasave file " + pathname
System.err.println("Created metasave file " + pathname
+ " in the log directory of namenode " + proxy.getAddress()
+ " failed");
exceptions.add(ioe);
Expand Down Expand Up @@ -1698,7 +1698,7 @@ public int refreshServiceAcl() throws IOException {
System.out.println("Refresh service acl successful for "
+ proxy.getAddress());
}catch (IOException ioe){
System.out.println("Refresh service acl failed for "
System.err.println("Refresh service acl failed for "
+ proxy.getAddress());
exceptions.add(ioe);
}
Expand Down Expand Up @@ -1751,7 +1751,7 @@ public int refreshUserToGroupsMappings() throws IOException {
System.out.println("Refresh user to groups mapping successful for "
+ proxy.getAddress());
}catch (IOException ioe){
System.out.println("Refresh user to groups mapping failed for "
System.err.println("Refresh user to groups mapping failed for "
+ proxy.getAddress());
exceptions.add(ioe);
}
Expand Down Expand Up @@ -1806,7 +1806,7 @@ public int refreshSuperUserGroupsConfiguration() throws IOException {
System.out.println("Refresh super user groups configuration " +
"successful for " + proxy.getAddress());
}catch (IOException ioe){
System.out.println("Refresh super user groups configuration " +
System.err.println("Refresh super user groups configuration " +
"failed for " + proxy.getAddress());
exceptions.add(ioe);
}
Expand Down Expand Up @@ -1855,7 +1855,7 @@ public int refreshCallQueue() throws IOException {
System.out.println("Refresh call queue successful for "
+ proxy.getAddress());
}catch (IOException ioe){
System.out.println("Refresh call queue failed for "
System.err.println("Refresh call queue failed for "
+ proxy.getAddress());
exceptions.add(ioe);
}
Expand Down
Loading