YARN-11102. Fix spotbugs error in hadoop-sls module #4117

szilard-nemeth · 2022-03-29T15:36:53Z

Description of PR

How was this patch tested?

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2022-03-29T17:22:52Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 55s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	37m 7s		trunk passed
+1 💚	compile	0m 27s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	0m 24s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 21s		trunk passed
+1 💚	mvnsite	0m 28s		trunk passed
+1 💚	javadoc	0m 25s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 24s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 ❌	spotbugs	0m 48s	/branch-spotbugs-hadoop-tools_hadoop-sls-warnings.html	hadoop-tools/hadoop-sls in trunk has 2 extant spotbugs warnings.
+1 💚	shadedclient	23m 9s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 21s		the patch passed
+1 💚	compile	0m 21s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	0m 21s		the patch passed
+1 💚	compile	0m 19s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 19s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 13s		the patch passed
+1 💚	mvnsite	0m 21s		the patch passed
+1 💚	javadoc	0m 19s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 17s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	0m 50s		the patch passed
+1 💚	shadedclient	23m 9s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	12m 3s		hadoop-sls in the patch passed.
+1 💚	asflicense	0m 30s		The patch does not generate ASF License warnings.
		104m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4117/1/artifact/out/Dockerfile
GITHUB PR	#4117
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 14e36abe0cd0 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 461d6a851f8338fbed5c83a8e7f8147bffb6fe84
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4117/1/testReport/
Max. process+thread count	520 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4117/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

9uapaw · 2022-03-31T11:09:20Z

The first spotbugs error could be eliminated by:

Wrapping inputTraces in an unmodifiable collection or an immutable one from Guava
The second is trickier, because I have a feeling that it is not easy to make it non-static. Nonetheless, we need to try it.

hadoop-yetus · 2022-03-31T17:48:01Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 6s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 38s		trunk passed
+1 💚	compile	0m 38s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	0m 35s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 29s		trunk passed
+1 💚	mvnsite	0m 44s		trunk passed
+1 💚	javadoc	0m 41s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 35s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 ❌	spotbugs	1m 7s	/branch-spotbugs-hadoop-tools_hadoop-sls-warnings.html	hadoop-tools/hadoop-sls in trunk has 3 extant spotbugs warnings.
+1 💚	shadedclient	28m 41s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 29s		the patch passed
+1 💚	compile	0m 29s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	0m 29s		the patch passed
+1 💚	compile	0m 23s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 23s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 18s		the patch passed
+1 💚	mvnsite	0m 30s		the patch passed
+1 💚	javadoc	0m 28s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 24s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	1m 5s		the patch passed
+1 💚	shadedclient	27m 49s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	12m 44s		hadoop-sls in the patch passed.
+1 💚	asflicense	0m 40s		The patch does not generate ASF License warnings.
		123m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4117/2/artifact/out/Dockerfile
GITHUB PR	#4117
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux e8cd24aba66f 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / c8de42a75644bee9b9cb56366611c5d16c18d8ed
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4117/2/testReport/
Max. process+thread count	578 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4117/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-04-01T11:19:21Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 53s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	38m 57s		trunk passed
+1 💚	compile	0m 32s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	0m 27s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 23s		trunk passed
+1 💚	mvnsite	0m 34s		trunk passed
+1 💚	javadoc	0m 31s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 27s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 ❌	spotbugs	0m 56s	/branch-spotbugs-hadoop-tools_hadoop-sls-warnings.html	hadoop-tools/hadoop-sls in trunk has 3 extant spotbugs warnings.
+1 💚	shadedclient	24m 24s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 23s		the patch passed
+1 💚	compile	0m 25s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	0m 25s		the patch passed
+1 💚	compile	0m 22s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 22s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 14s	/results-checkstyle-hadoop-tools_hadoop-sls.txt	hadoop-tools/hadoop-sls: The patch generated 6 new + 33 unchanged - 1 fixed = 39 total (was 34)
+1 💚	mvnsite	0m 24s		the patch passed
+1 💚	javadoc	0m 23s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 19s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	1m 0s		hadoop-tools/hadoop-sls generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3)
+1 💚	shadedclient	24m 16s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	12m 21s		hadoop-sls in the patch passed.
+1 💚	asflicense	0m 32s		The patch does not generate ASF License warnings.
		110m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4117/3/artifact/out/Dockerfile
GITHUB PR	#4117
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux e898f3fda25c 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `0420016`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4117/3/testReport/
Max. process+thread count	521 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4117/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

szilard-nemeth · 2022-04-01T13:18:43Z

Seems like the following Spotbugs warnings are not valid anymore as I fixed them with the commit 0420016.
However, somehow Spotbugs still shows them as warnings which I don't really get.
Also, I installed Spotbugs in my IntelliJ IDEA and it doesn't report the warning on my local machine.

The warnings:

1. org.apache.hadoop.yarn.sls.AMRunner.setInputTraces(String[]) may expose internal representation by storing an externally mutable object into AMRunner.inputTraces

2. Write to static field org.apache.hadoop.yarn.sls.AMRunner.remainingApps from instance method org.apache.hadoop.yarn.sls.AMRunner.startAM()

The other warning will be fixed with the commit I created just now:

org.apache.hadoop.yarn.sls.NMRunner.setInputTraces(String[]) may expose internal representation by storing an externally mutable object into NMRunner.inputTraces

hadoop-yetus · 2022-04-01T15:04:23Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 57s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	36m 22s		trunk passed
+1 💚	compile	0m 27s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	0m 24s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 21s		trunk passed
+1 💚	mvnsite	0m 29s		trunk passed
+1 💚	javadoc	0m 26s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 24s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 ❌	spotbugs	0m 48s	/branch-spotbugs-hadoop-tools_hadoop-sls-warnings.html	hadoop-tools/hadoop-sls in trunk has 3 extant spotbugs warnings.
+1 💚	shadedclient	23m 28s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 20s		the patch passed
+1 💚	compile	0m 22s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	0m 22s		the patch passed
+1 💚	compile	0m 18s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 18s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 12s	/results-checkstyle-hadoop-tools_hadoop-sls.txt	hadoop-tools/hadoop-sls: The patch generated 6 new + 46 unchanged - 1 fixed = 52 total (was 47)
+1 💚	mvnsite	0m 22s		the patch passed
+1 💚	javadoc	0m 19s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 18s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	0m 50s		hadoop-tools/hadoop-sls generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3)
+1 💚	shadedclient	23m 7s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	12m 3s		hadoop-sls in the patch passed.
+1 💚	asflicense	0m 29s		The patch does not generate ASF License warnings.
		103m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4117/4/artifact/out/Dockerfile
GITHUB PR	#4117
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 486f13de9794 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `de47910`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4117/4/testReport/
Max. process+thread count	577 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4117/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

9uapaw · 2022-04-01T16:47:20Z

Thanks for the change @szilard-nemeth. A very straightforward one, LGTM. Committed to trunk.

szilard-nemeth force-pushed the YARN-11102 branch from 461d6a8 to c8de42a Compare March 31, 2022 15:42

YARN-11102.002

0420016

szilard-nemeth force-pushed the YARN-11102 branch from c8de42a to 0420016 Compare April 1, 2022 09:27

Fix one more Spotbugs warning

de47910

9uapaw closed this Apr 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YARN-11102. Fix spotbugs error in hadoop-sls module #4117

YARN-11102. Fix spotbugs error in hadoop-sls module #4117

Uh oh!

szilard-nemeth commented Mar 29, 2022

Uh oh!

hadoop-yetus commented Mar 29, 2022

Uh oh!

9uapaw commented Mar 31, 2022

Uh oh!

hadoop-yetus commented Mar 31, 2022

Uh oh!

hadoop-yetus commented Apr 1, 2022

Uh oh!

szilard-nemeth commented Apr 1, 2022

Uh oh!

hadoop-yetus commented Apr 1, 2022

Uh oh!

9uapaw commented Apr 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

YARN-11102. Fix spotbugs error in hadoop-sls module #4117

YARN-11102. Fix spotbugs error in hadoop-sls module #4117

Uh oh!

Conversation

szilard-nemeth commented Mar 29, 2022

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Mar 29, 2022

Uh oh!

9uapaw commented Mar 31, 2022

Uh oh!

hadoop-yetus commented Mar 31, 2022

Uh oh!

hadoop-yetus commented Apr 1, 2022

Uh oh!

szilard-nemeth commented Apr 1, 2022

Uh oh!

hadoop-yetus commented Apr 1, 2022

Uh oh!

9uapaw commented Apr 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants