HDFS-16522. Set Http and Ipc ports for Datanodes in MiniDFSCluster #4108

virajjasani · 2022-03-25T16:49:48Z

Description of PR

Provide options to set Http and Ipc ports for Datanodes in MiniDFSCluster.

How was this patch tested?

UT

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?

hadoop-yetus · 2022-03-26T00:32:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 39s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 7 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	12m 43s		Maven dependency ordering for branch
+1 💚	mvninstall	24m 35s		trunk passed
+1 💚	compile	24m 27s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	20m 41s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	3m 31s		trunk passed
+1 💚	mvnsite	2m 29s		trunk passed
+1 💚	javadoc	1m 49s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	2m 23s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 25s		trunk passed
+1 💚	shadedclient	21m 30s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 29s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 41s		the patch passed
+1 💚	compile	23m 39s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	23m 39s		the patch passed
+1 💚	compile	20m 54s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	20m 54s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	3m 44s	/results-checkstyle-root.txt	root: The patch generated 1 new + 198 unchanged - 1 fixed = 199 total (was 199)
+1 💚	mvnsite	2m 29s		the patch passed
+1 💚	javadoc	1m 39s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	2m 48s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 48s		the patch passed
+1 💚	shadedclient	21m 3s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	227m 23s		hadoop-hdfs in the patch passed.
-1 ❌	unit	1m 20s	/patch-unit-hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-infra.txt	hadoop-dynamometer-infra in the patch failed.
+1 💚	asflicense	1m 11s		The patch does not generate ASF License warnings.
		437m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4108/1/artifact/out/Dockerfile
GITHUB PR	#4108
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 11927f13dcae 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `bff2357`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4108/1/testReport/
Max. process+thread count	3370 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-infra U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4108/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

virajjasani · 2022-03-26T09:09:02Z

hadoop-dynamometer-infra failure is not relevant because the mvn test doesn't seem to be running after compiling hadoop-hdfs module from this patch.

Running the same in local:

$ mvn -Pparallel-tests -Pnative -Drequire.fuse -Drequire.openssl -Drequire.snappy -Drequire.valgrind -Drequire.zstd -Drequire.test.libhadoop -Pyarn-ui clean test -fae

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.tools.dynamometer.TestDynamometerInfra
[WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.004 s - in org.apache.hadoop.tools.dynamometer.TestDynamometerInfra
[INFO] Running org.apache.hadoop.tools.dynamometer.TestDynoInfraUtils
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.109 s - in org.apache.hadoop.tools.dynamometer.TestDynoInfraUtils
[INFO] 
[INFO] Results:
[INFO] 
[WARNING] Tests run: 3, Failures: 0, Errors: 0, Skipped: 1
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  5.325 s
[INFO] Finished at: 2022-03-26T14:38:43+05:30
[INFO] ------------------------------------------------------------------------

virajjasani · 2022-03-26T09:22:21Z

@ayushtkn Could you please review this PR? It's quite similar to #4028

hadoop-yetus · 2022-03-26T16:32:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 38s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 7 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	12m 50s		Maven dependency ordering for branch
+1 💚	mvninstall	23m 28s		trunk passed
+1 💚	compile	22m 50s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	19m 56s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	3m 35s		trunk passed
+1 💚	mvnsite	2m 31s		trunk passed
+1 💚	javadoc	2m 1s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	2m 28s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 24s		trunk passed
+1 💚	shadedclient	20m 54s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 28s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 37s		the patch passed
+1 💚	compile	22m 2s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	22m 2s		the patch passed
+1 💚	compile	20m 5s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	20m 5s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	3m 39s		root: The patch generated 0 new + 198 unchanged - 1 fixed = 198 total (was 199)
+1 💚	mvnsite	2m 24s		the patch passed
+1 💚	javadoc	1m 58s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	2m 30s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 40s		the patch passed
+1 💚	shadedclient	21m 10s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	238m 19s		hadoop-hdfs in the patch passed.
+1 💚	unit	0m 47s		hadoop-dynamometer-infra in the patch passed.
+1 💚	asflicense	1m 4s		The patch does not generate ASF License warnings.
		441m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4108/2/artifact/out/Dockerfile
GITHUB PR	#4108
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 4a1b12483ab0 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `7e38d93`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4108/2/testReport/
Max. process+thread count	3248 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-infra U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4108/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

aajisaka · 2022-03-27T12:58:34Z

hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java

+      Configuration[] dnConfOverlays,
+      int[] dnHttpPorts,
+      int[] dnIpcPorts) throws IOException {


I think it is a safe change. This class is @InterfaceAudience.LimitedPrivate({"HBase", "HDFS", "Hive", "MapReduce", "Pig"}). I checked the source code of Hive, HBase, and Pig. The method signature is not used anywhere.

hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMiniDFSCluster.java

aajisaka · 2022-03-27T13:19:06Z

Thank you @virajjasani for your patch.

The test maybe flaky when there are multiple tests running in parallel because some test can bind the port that is collected by NetUtils.getFreeSocketPorts(6) before launching DataNodes. Now I don't think we can fix it, so I recommend to add a comment to the test that the test can fail when one the free ports are used by other applications.

virajjasani · 2022-03-27T17:29:34Z

so I recommend to add a comment to the test that the test can fail when one the free ports are used by other applications.

Done, thanks.

hadoop-yetus · 2022-03-28T01:06:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 40s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 7 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	12m 34s		Maven dependency ordering for branch
+1 💚	mvninstall	23m 33s		trunk passed
+1 💚	compile	25m 7s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	22m 25s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	4m 10s		trunk passed
+1 💚	mvnsite	2m 30s		trunk passed
+1 💚	javadoc	1m 52s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	2m 34s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 47s		trunk passed
+1 💚	shadedclient	23m 39s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 29s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 47s		the patch passed
+1 💚	compile	25m 36s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	25m 36s		the patch passed
+1 💚	compile	22m 41s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	22m 41s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	3m 55s		root: The patch generated 0 new + 198 unchanged - 1 fixed = 198 total (was 199)
+1 💚	mvnsite	2m 33s		the patch passed
+1 💚	javadoc	2m 2s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	2m 29s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	5m 19s		the patch passed
+1 💚	shadedclient	24m 18s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	233m 29s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	unit	1m 8s		hadoop-dynamometer-infra in the patch passed.
+1 💚	asflicense	1m 10s		The patch does not generate ASF License warnings.
		456m 14s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestRollingUpgrade

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4108/3/artifact/out/Dockerfile
GITHUB PR	#4108
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 93c06166adba 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `5dacc26`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4108/3/testReport/
Max. process+thread count	3120 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-infra U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4108/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-03-31T17:41:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 7 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	11m 37s		Maven dependency ordering for branch
+1 💚	mvninstall	22m 59s		trunk passed
+1 💚	compile	22m 52s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	20m 2s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	3m 37s		trunk passed
+1 💚	mvnsite	2m 27s		trunk passed
+1 💚	javadoc	2m 1s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	2m 28s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 27s		trunk passed
+1 💚	shadedclient	20m 55s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 28s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 37s		the patch passed
+1 💚	compile	22m 0s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	22m 0s		the patch passed
+1 💚	compile	20m 3s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	20m 3s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	3m 34s		root: The patch generated 0 new + 198 unchanged - 1 fixed = 198 total (was 199)
+1 💚	mvnsite	2m 28s		the patch passed
+1 💚	javadoc	1m 57s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	2m 30s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 46s		the patch passed
+1 💚	shadedclient	21m 1s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	227m 37s		hadoop-hdfs in the patch passed.
+1 💚	unit	0m 58s		hadoop-dynamometer-infra in the patch passed.
+1 💚	asflicense	1m 11s		The patch does not generate ASF License warnings.
		430m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4108/4/artifact/out/Dockerfile
GITHUB PR	#4108
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 33b5bbd5ecda 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `365bf2c`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4108/4/testReport/
Max. process+thread count	2995 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-infra U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4108/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-03-31T20:05:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 58s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 7 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	11m 18s		Maven dependency ordering for branch
+1 💚	mvninstall	25m 54s		trunk passed
+1 💚	compile	25m 12s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	21m 21s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	3m 54s		trunk passed
+1 💚	mvnsite	2m 17s		trunk passed
+1 💚	javadoc	1m 47s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	2m 12s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 22s		trunk passed
+1 💚	shadedclient	24m 2s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 23s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 39s		the patch passed
+1 💚	compile	24m 9s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	24m 9s		the patch passed
+1 💚	compile	21m 19s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	21m 19s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	3m 54s		root: The patch generated 0 new + 198 unchanged - 1 fixed = 198 total (was 199)
+1 💚	mvnsite	2m 11s		the patch passed
+1 💚	javadoc	1m 43s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	2m 14s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 44s		the patch passed
+1 💚	shadedclient	24m 7s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	357m 33s		hadoop-hdfs in the patch passed.
+1 💚	unit	0m 45s		hadoop-dynamometer-infra in the patch passed.
+1 💚	asflicense	0m 58s		The patch does not generate ASF License warnings.
		573m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4108/5/artifact/out/Dockerfile
GITHUB PR	#4108
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 46130fa85bcb 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `365bf2c`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4108/5/testReport/
Max. process+thread count	2100 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-infra U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4108/5/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

virajjasani · 2022-04-02T17:48:12Z

@aajisaka I have addressed the comments in the latest revision. Could you please take a look when you get the bandwidth?

aajisaka

+1. Thank you @virajjasani

virajjasani · 2022-04-05T11:50:41Z

Thank you @aajisaka for the review.

virajjasani · 2022-04-06T06:56:02Z

Is this good for merging? Thanks

aajisaka · 2022-04-06T09:17:12Z

Merged. Thank you @virajjasani for your contribution!

…4108) Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit 7c20602)

…pache#4108) Signed-off-by: Akira Ajisaka <[email protected]>

HDFS-16522. Set Http and Ipc ports for Datanodes in MiniDFSCluster

bff2357

addendum

7e38d93

aajisaka reviewed Mar 27, 2022

View reviewed changes

hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMiniDFSCluster.java Outdated Show resolved Hide resolved

comment to clarify possibility of test failure

5dacc26

virajjasani requested a review from aajisaka March 29, 2022 10:38

incorporating review

365bf2c

aajisaka approved these changes Apr 2, 2022

View reviewed changes

aajisaka merged commit 7c20602 into apache:trunk Apr 6, 2022

aajisaka pushed a commit that referenced this pull request Apr 6, 2022

HDFS-16522. Set Http and Ipc ports for Datanodes in MiniDFSCluster (#…

b2eee14

…4108) Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit 7c20602)

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022

HDFS-16522. Set Http and Ipc ports for Datanodes in MiniDFSCluster (a…

8406ca5

…pache#4108) Signed-off-by: Akira Ajisaka <[email protected]>

HDFS-16522. Set Http and Ipc ports for Datanodes in MiniDFSCluster #4108

HDFS-16522. Set Http and Ipc ports for Datanodes in MiniDFSCluster #4108

Uh oh!

Conversation

virajjasani commented Mar 25, 2022

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Mar 26, 2022

Uh oh!

virajjasani commented Mar 26, 2022

Uh oh!

virajjasani commented Mar 26, 2022

Uh oh!

hadoop-yetus commented Mar 26, 2022

Uh oh!

aajisaka Mar 27, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aajisaka commented Mar 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

virajjasani commented Mar 27, 2022

Uh oh!

hadoop-yetus commented Mar 28, 2022

Uh oh!

hadoop-yetus commented Mar 31, 2022

Uh oh!

hadoop-yetus commented Mar 31, 2022

Uh oh!

virajjasani commented Apr 2, 2022

Uh oh!

aajisaka left a comment

Choose a reason for hiding this comment

Uh oh!

virajjasani commented Apr 5, 2022

Uh oh!

virajjasani commented Apr 6, 2022

Uh oh!

aajisaka commented Apr 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aajisaka commented Mar 27, 2022 •

edited

Loading