HDFS-16509. Fix decommission UnsupportedOperationException#4077
Merged
Hexiaoqiao merged 2 commits intoapache:trunkfrom Apr 14, 2022
Merged
HDFS-16509. Fix decommission UnsupportedOperationException#4077Hexiaoqiao merged 2 commits intoapache:trunkfrom
Hexiaoqiao merged 2 commits intoapache:trunkfrom
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
tomscut
approved these changes
Mar 24, 2022
Contributor
tomscut
left a comment
tomscut
left a comment
There was a problem hiding this comment.
LGTM.
If you do decommission, you can try DatanodeAdminBackoffMonitor. This has better performance.
Contributor
Author
|
@tomscut Thanks for your review and advice! |
Contributor
|
Thanks @cndaimin for your great catch here. Would you mind to add new unit test to cover this case? Thanks. |
Contributor
Author
|
Hi @Hexiaoqiao Thanks for your review! I have added a test to this PR. Please take a look again, thanks. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
great catch! Is this the reason that sometimes decomm never completes? |
Contributor
Author
|
@jojochuang Yes, the exception is not well handled, and will make decommission stuck. |
|
🎊 +1 overall
This message was automatically generated. |
Hexiaoqiao
reviewed
Apr 13, 2022
| waitNodeDecommissioned(dn); | ||
| } | ||
|
|
||
| private void waitNodeDecommissioned(DatanodeInfo node) { |
Contributor
There was a problem hiding this comment.
Hi @cndaimin, I think we could invoke this method rather than add new one, what do you think about?
Contributor
Author
There was a problem hiding this comment.
Yes, we can use this method, updated. Thanks a lot! @Hexiaoqiao
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
Committed to trunk. Thanks @cndaimin for your contributions. Thanks @jojochuang @tomscut for your reviews. |
Contributor
Author
|
@Hexiaoqiao I think it would be better to backport. Thanks @Hexiaoqiao @jojochuang @tomscut |
asfgit
pushed a commit
that referenced
this pull request
Apr 14, 2022
…ontributed by daimin. (cherry picked from commit c65c383)
Contributor
|
Cherrypicked cleanly and pushed to branch-3.3. |
Contributor
Author
|
@jojochuang I have submitted a new PR here: Backport HDFS-16509 to branch branch-3.2 to resolve the conflicts. Please take a look, thanks! |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…). Contributed by daimin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We encountered an
UnsupportedOperationException: Remove unsupportederror when some datanodes were in decommission. The reason of the exception is thatdatanode.getBlockIterator()returns an Iterator does not support remove, howeverDatanodeAdminDefaultMonitor#processBlocksInternalinvokesit.remove()when a block not found, e.g, the file containing the block is deleted.