HDFS-16499. [SPS]: Should not start indefinitely while another SPS process is running #4058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
Contributor
There was a problem hiding this comment.
It's quite some time I looked at this code. Thanks a lot for working on these improvements.
How about using ExitUtil class to terminate. That class has static methods to disable exit. That you can use it from tests.
Contributor
Author
There was a problem hiding this comment.
It's quite some time I looked at this code. Thanks a lot for working on these improvements. How about using ExitUtil class to terminate. That class has static methods to disable exit. That you can use it from tests.
Thank you @umamaheswararao very much for your review. And your suggestion makes sense to me.
I updated the code. PTAL. Thanks.
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
Hi @umamaheswararao , could you please take a look at this? Thank you very much. |
Contributor
umamaheswararao
left a comment
umamaheswararao
left a comment
There was a problem hiding this comment.
Patch almost looks good to me. I have a minor comment in test though.
| () -> ExternalStoragePolicySatisfier.getNameNodeConnector(config)); | ||
|
|
||
| // Reset first exit exception to avoid AssertionError in MiniDFSCluster#shutdown. | ||
| // This has no effect on functionality. |
Contributor
There was a problem hiding this comment.
How about doing this reset in finally?
Contributor
Author
There was a problem hiding this comment.
How about doing this reset in finally?
Thanks @umamaheswararao for your comments. I fixed it.
umamaheswararao
approved these changes
Mar 15, 2022
Contributor
umamaheswararao
left a comment
umamaheswararao
left a comment
There was a problem hiding this comment.
+1 LGTM, pending CI
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
Hi @umamaheswararao , could you please help merge this? Thank you. |
Contributor
|
@tomscut Thanks for your contribution. @umamaheswararao Thanks for your review! Merged |
Contributor
Author
|
Thanks @umamaheswararao and @ferhui . |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…ocess is running (apache#4058)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: HDFS-16499.
Normally, we can only start one SPS process at a time. When one process is running, start another process and retry indefinitely. I think, in this case, we should exit immediately.