HADOOP-17526 Use Slf4jRequestLog for HttpRequestLog #4050
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Use Slf4jRequestLog in HttpRequestLog, so we do not need to depend on actual log appender implementations in code.
For keeping the rolling way the safe, I have to use DailyRollingFileAppender but the DRFA in log4j1 does not support removing old files, so we loss the ability of 'RetainDays'. Anyway, later after we upgrade to log4j2, we can add this ability back.
How was this patch tested?
Introduced a new UT. Better to deploy a hadoop cluster, enable request log and check the output.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?