-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-16494.Removed reuse of AvailableSpaceVolumeChoosingPolicy#initLocks(). #4048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
Here are some unit tests that are failing. E.g: It looks like these exceptions have little to do with the update I submitted. |
tomscut
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
Thanks @tomscut . |
|
Can you help review this pr, @Hexiaoqiao @ferhui . |
Hexiaoqiao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. +1.
|
Thanks @Hexiaoqiao . |
…cks(). (#4048). Contributed by JiangHua Zhu.
|
Committed to trunk. Thanks @jianghuazhu for your contributions! Thanks @tomscut reviews! |
…cks(). (apache#4048). Contributed by JiangHua Zhu.
Description of PR
When using the default constructor to build the AvailableSpaceVolumeChoosingPolicy, initLocks() is used twice, which is actually unnecessary, the purpose of this pr is to avoid this from happening.
Details: HDFS-16494
How was this patch tested?
Not too stressful for testing. Because this class is relatively mature.