HADOOP-18110. ViewFileSystem: Add Support for Localized Trash Root #3956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
added 2 commits
February 4, 2022 11:50
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
omalley
requested changes
Feb 9, 2022
Contributor
omalley
left a comment
omalley
left a comment
There was a problem hiding this comment.
This is looking good. I'd like one more test and to fix the javadoc breakage.
...p-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
Outdated
Show resolved
Hide resolved
| Assert.assertTrue("", fsView.getTrashRoots(true).size() > 0); | ||
| } | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
Please add a test where the child file system returns a root inside of the mount point, such as what will happen when there is an encryption zone root. To do so, you'll need to define a mock/stub fs.
Contributor
Author
There was a problem hiding this comment.
Hi @omalley,
I believe Case 5 is what you are looking for. 😃
Contributor
There was a problem hiding this comment.
Actually, it isn't. I was more concerned with what would happen with an encryption zone or snapshot root. You'd need to make a mock child file system that implements a custom getTrashRoot(path).
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
xinglin
pushed a commit
to xinglin/hadoop
that referenced
this pull request
Feb 16, 2022
Fixes apache#3956 (cherry picked from commit ca8ba24)
omalley
pushed a commit
that referenced
this pull request
Feb 16, 2022
Fixes #3956 Fixes #3994 (cherry picked from commit ca8ba24) Signed-off-by: Owen O'Malley <[email protected]>
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
We modified getTrashRoot()/getTrashRoots() in ViewFileSystem to return a localized trash root that is within a mount point when CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH is set.
How was this patch tested?
mvn test -Dtest=TestView*
Manually ran three newly added unit tests using intellij.