-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-16437 ReverseXML processor doesn't accept XML files without the … #3926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…SnapshotDiffSection
|
💔 -1 overall
This message was automatically generated. |
…SnapshotDiffSection
|
💔 -1 overall
This message was automatically generated. |
…SnapshotDiffSection
|
🎊 +1 overall
This message was automatically generated. |
|
Hello @tasanuma @jojochuang @goiri @aajisaka @ayushtkn ,PTAL. Thanks a lot. |
...fs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
Outdated
Show resolved
Hide resolved
...fs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
Show resolved
Hide resolved
...fs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
The failed check has nothing to do with my changes, the last check passed. @jojochuang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line doesn't compile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reminding me, I was careless.
singer-bin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add terminator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reminding me, I was careless.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
jojochuang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 thanks for working on the PR.
|
This check failure has nothing to do with my commit, please review! @jojochuang |
|
Hi, @jojochuang ,could you please merge this PR |
apache#3926) (cherry picked from commit 125e3b6) Change-Id: I03e4f2af17f0e4a8245c9c2c8ea1cb2cb41f777a
apache#3926) (cherry picked from commit 125e3b6) Change-Id: I03e4f2af17f0e4a8245c9c2c8ea1cb2cb41f777a
…SnapshotDiffSection
Description of PR
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?