Skip to content

HDFS-16427. Add debug log for BlockManager#chooseExcessRedundancyStriped #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tasanuma merged 4 commits into from
Jan 27, 2022
Merged

HDFS-16427. Add debug log for BlockManager#chooseExcessRedundancyStriped #3888

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b9c642a
HDFS-16427. Add debug log for BlockManager#chooseExcessRedundancyStriped
tomscut Jan 13, 2022
509cac8
simplify the log
tomscut Jan 24, 2022
c61ec23
update log, add precondition
tomscut Jan 26, 2022
69e22b5
update log info
tomscut Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4047,6 +4047,14 @@ private void chooseExcessRedundancyStriped(BlockCollection bc,
List<DatanodeStorageInfo> replicasToDelete = placementPolicy
.chooseReplicasToDelete(nonExcess, candidates, (short) 1,
excessTypes, null, null);
if (LOG.isDebugEnabled()) {
LOG.debug("Choose redundant EC replicas to delete from blk_{} which is located in {}",
sblk.getBlockId(), storage2index);
LOG.debug("Storages with candidate blocks to be deleted: {}", candidates);
LOG.debug("Storages with blocks to be deleted: {}", replicasToDelete);
}
Preconditions.checkArgument(candidates.containsAll(replicasToDelete),
"The EC replicas to be deleted are not in the candidate list");
for (DatanodeStorageInfo chosen : replicasToDelete) {
processChosenExcessRedundancy(nonExcess, chosen, storedBlock);
candidates.remove(chosen);
Expand Down