-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-16401.Remove the worthless DatasetVolumeChecker#numAsyncDatasetChecks. #3838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
Some failed unit tests were found in UT, such as: It seems that these failures have little to do with my changes. |
tomscut
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After HDFS-11279, numAsyncDatasetChecks is not used.
LGTM.
|
Thanks @tomscut . |
|
Can you help review this pr, @jojochuang @ferhui . |
|
Thanks @ferhui . |
ayushtkn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
Thanks @ayushtkn . |
|
Hi @ferhui , can this pr be merged into trunk branch or other main branch? |
|
@jianghuazhu Thanks for your contribution. @ayushtkn Thanks for your review! Merged. |
Description of PR
It seems that cleaning up DatasetVolumeChecker#numAsyncDatasetChecks was ignored before this.
Details: HDFS-16401
How was this patch tested?
For testing, there is not much pressure.