HDFS-16389.Improve NNThroughputBenchmark test mkdirs.#3819
Merged
jojochuang merged 1 commit intoapache:trunkfrom Apr 18, 2022
Merged
HDFS-16389.Improve NNThroughputBenchmark test mkdirs.#3819jojochuang merged 1 commit intoapache:trunkfrom
jojochuang merged 1 commit intoapache:trunkfrom
Conversation
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
Could you help review this pr, @aajisaka @virajjasani . |
jojochuang
reviewed
Dec 22, 2021
Contributor
There was a problem hiding this comment.
It would be really nice to suggest a valid range of number of directories or files. For example, up to 1 million directories?
Contributor
Author
There was a problem hiding this comment.
Thanks @jojochuang for the comment and review.
I agree with your suggestion, and I will update it later.
jianghuazhu
force-pushed
the
HDFS-16389
branch
from
3229263 to
d1a4ee9
Compare
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
Could you help review this pr again @jojochuang . |
Contributor
|
@jianghuazhu Could you also take care of checkstyle warnings? Changes look good overall. |
jianghuazhu
force-pushed
the
HDFS-16389
branch
from
d1a4ee9 to
619cb54
Compare
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
I have updated some, can you please review this pr again, @virajjasani . |
aajisaka
reviewed
Dec 24, 2021
Comment on lines
581
to
582
Member
There was a problem hiding this comment.
It's more simple
Suggested change
| } catch (Exception e) { | |
| if (e instanceof ArrayIndexOutOfBoundsException) { | |
| } catch (ArrayIndexOutOfBoundsException e) { |
aajisaka
reviewed
Dec 24, 2021
Comment on lines
697
to
698
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Thank you very much.
I will update it later.
jianghuazhu
force-pushed
the
HDFS-16389
branch
from
619cb54 to
5d80ac1
Compare
jianghuazhu
force-pushed
the
HDFS-16389
branch
from
5d80ac1 to
97e5c23
Compare
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
I have updated some, can you please review this pr again, @aajisaka . |
Contributor
|
+1 (non-binding) with the latest change |
Contributor
Author
|
Thank you very much @virajjasani . |
jojochuang
approved these changes
Apr 18, 2022
asfgit
pushed a commit
that referenced
this pull request
Apr 19, 2022
Reviewed-by: Viraj Jasani <vjasani@apache.org> Reviewed-by: Akira Ajisaka <aajisaka@apache.org> Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org> (cherry picked from commit 900682e) (cherry picked from commit 4aa9698ee1e9a10a0f882229036bbb4db1ede939)
asfgit
pushed a commit
that referenced
this pull request
Apr 19, 2022
Reviewed-by: Viraj Jasani <vjasani@apache.org> Reviewed-by: Akira Ajisaka <aajisaka@apache.org> Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org> (cherry picked from commit 900682e)
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Reviewed-by: Viraj Jasani <vjasani@apache.org> Reviewed-by: Akira Ajisaka <aajisaka@apache.org> Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
When using the NNThroughputBenchmark test to create a large number of directories, an exception message that the queue is out of bounds will be prompted.
How was this patch tested?
For testing, there is not much pressure.