Skip to content

Conversation

@aajisaka
Copy link
Member

@aajisaka aajisaka commented Dec 19, 2021

Description of PR

Use Dockerfile_aarch64 in Apple Silicon.

How was this patch tested?

Manually tested in M1 Pro MBP. However, Docker for Mac with Apple Silicon is too slow to develop.

bash-3.2$ echo $MACHTYPE
arm64-apple-darwin21
bash-3.2$ echo "$MACHTYPE" | cut -d- -f1
arm64

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • n/a Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • n/a If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • n/a If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 42s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 shelldocs 0m 1s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 32m 31s trunk passed
+1 💚 mvnsite 25m 32s trunk passed
+1 💚 shadedclient 19m 19s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 21m 38s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 20m 52s the patch passed
+1 💚 shellcheck 0m 1s No new issues.
+1 💚 shadedclient 19m 21s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 20m 14s root in the patch passed.
+1 💚 asflicense 0m 58s The patch does not generate ASF License warnings.
163m 21s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3817/1/artifact/out/Dockerfile
GITHUB PR #3817
Optional Tests dupname asflicense mvnsite unit codespell shellcheck shelldocs
uname Linux 29a577135798 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 225fd8f
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3817/1/testReport/
Max. process+thread count 716 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3817/1/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@aajisaka aajisaka merged commit c8725de into apache:trunk Dec 23, 2021
@aajisaka aajisaka deleted the HADOOP-18052 branch December 23, 2021 09:13
@aajisaka
Copy link
Member Author

Merged. Thank you @jojochuang

aajisaka added a commit that referenced this pull request Dec 23, 2021
Reviewed-by: Wei-Chiu Chuang <weichiu@apache.org>
(cherry picked from commit c8725de)
sunchao pushed a commit that referenced this pull request Jan 4, 2022
Reviewed-by: Wei-Chiu Chuang <weichiu@apache.org>
(cherry picked from commit c8725de)
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
Reviewed-by: Wei-Chiu Chuang <weichiu@apache.org>
symious pushed a commit to symious/hadoop that referenced this pull request Nov 21, 2024
Reviewed-by: Wei-Chiu Chuang <weichiu@apache.org>
(cherry picked from commit c8725de)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants