Skip to content

YARN-10427. Duplicate Job IDs in SLS output #3809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shuzirra merged 2 commits into from
Dec 16, 2021
Merged

YARN-10427. Duplicate Job IDs in SLS output #3809

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b708a0
YARN-10427. 003
szilard-nemeth Dec 22, 2020
8171e9c
YARN-10427. 004
szilard-nemeth Dec 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/appmaster/AMSimulator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
@Private
@Unstable
public abstract class AMSimulator extends TaskRunner.Task {
private static final long FINISH_TIME_NOT_INITIALIZED = Long.MIN_VALUE;
// resource manager
protected ResourceManager rm;
// main
Expand Down Expand Up @@ -102,7 +103,7 @@ public abstract class AMSimulator extends TaskRunner.Task {
protected long traceStartTimeMS;
protected long traceFinishTimeMS;
protected long simulateStartTimeMS;
protected long simulateFinishTimeMS;
protected long simulateFinishTimeMS = FINISH_TIME_NOT_INITIALIZED;
// whether tracked in Metrics
protected boolean isTracked;
// progress
Expand Down Expand Up @@ -226,6 +227,16 @@ public void middleStep() throws Exception {

@Override
public void lastStep() throws Exception {
if (simulateFinishTimeMS != FINISH_TIME_NOT_INITIALIZED) {
// The finish time is already recorded.
// Different value from zero means lastStep was called before.
// We want to prevent lastStep to be called more than once.
// See YARN-10427 for more details.
LOG.warn("Method AMSimulator#lastStep was already called. " +
"Skipping execution of method for application: {}", appId);
return;
}

LOG.info("Application {} is shutting down.", appId);
// unregister tracking
if (isTracked) {
Expand Down