HDFS-16359. RBF: RouterRpcServer#invokeAtAvailableNs does not take effect when retrying #3731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fect when retrying
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@goiri @hemanthboyina @jojochuang PTAL. Thanks. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
This failed UT |
Contributor
Author
Hi @ayushtkn , I found this unit test runs out of time several times. Can we just increase the timeout? |
tomscut
changed the title
goiri
reviewed
Nov 29, 2021
...-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
goiri
approved these changes
Nov 30, 2021
| * removing the already invoked namespaceinfo. | ||
| */ | ||
| private Set<FederationNamespaceInfo> getNameSpaceInfo(String nsId) { | ||
| private Set<FederationNamespaceInfo> getNameSpaceInfo( |
Contributor
Author
There was a problem hiding this comment.
Thanks @goiri for your comment, I noticed that this method is currently only called in one place. So do we still need to change it to static? Could you please give me some advice. Thank you very much.
Member
There was a problem hiding this comment.
I don't think this is too important to be honest.
There might be some minor optimization by being static but I do not think it is that important.
The main reason to make it static would be to make clear that this method is not doing anything with the attributes of the object.
Member
There was a problem hiding this comment.
BTW, if we are changing the signature of the method, I would also add final to the arguments.
Contributor
Author
There was a problem hiding this comment.
Thank you very much for your detailed reply. I have made some modifications, please have a look again.
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
goiri
approved these changes
Dec 1, 2021
Contributor
Author
|
Thank you @goiri very much for your review again. |
Member
|
One doubt here:
Then, So, if the first namespace returned after excluding the default namespace is also down. Then we would still get an error, right? despite having other namespace being available? Shouldn't this be a invokeSequential kind of stuff, try one by one all the namespaces until you get the result. Am I missing something here? |
Contributor
Author
Thanks @ayushtkn for your comments and detailed explanation. I think you are right. As described on line |
ayushtkn
approved these changes
Dec 1, 2021
Member
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
Makes sense, it was initialy implemented itself to try once only even in case of fault tolerance.
This PR is just fixing that behaviour.
Will raise a jira to track the change the retry mechanism to all available Namespaces…
@goiri does that makes sense?
Member
Yes, let's fix the current behavior and open a new JIRA with the general retry issue. |
Contributor
Author
Member
|
Merged, Thanx Everyone!!! |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…fect when retrying (apache#3731). Contributed by tomscut. Reviewed-by: Inigo Goiri <[email protected]> Signed-off-by: Ayush Saxena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: HDFS-16359.
RouterRpcServer#invokeAtAvailableNs does not take effect when retrying. See HDFS-15543.
The original code of RouterRpcServer#getNameSpaceInfo looks like follwings, and
namespaceInfosis always empty here.