HDFS-16314. Support to make dfs.namenode.block-placement-policy.exclude-slow-nodes.enabled reconfigurable #3664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 12, 2021 16:49
…de-slow-nodes.enabled reconfigurable
Contributor
Author
|
@tomscut Thank you for your reply. sorry, the previous PR exception was closed and created a new PR. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Hi @tomscut Is there anything else that needs to be improved in the current code? |
Contributor
Author
tomscut
reviewed
Nov 25, 2021
...ct/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
ferhui
approved these changes
Nov 26, 2021
aajisaka
reviewed
Dec 3, 2021
Comment on lines
+273
to
+275
| public abstract void setExcludeSlowNodesEnabled(boolean enable); | ||
|
|
||
| public abstract boolean getExcludeSlowNodesEnabled(); |
Member
There was a problem hiding this comment.
This interface is marked as @Private, so adding abstract methods is okay.
aajisaka
approved these changes
Dec 3, 2021
Member
|
Merged. Thank you @haiyang1987 for your contribution and thank you @ferhui @tomscut for your review. |
aajisaka
pushed a commit
that referenced
this pull request
Dec 3, 2021
…de-slow-nodes.enabled reconfigurable (#3664) Reviewed-by: Fei Hui <[email protected]> Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit c0f405a)
sunchao
pushed a commit
that referenced
this pull request
Jan 4, 2022
…de-slow-nodes.enabled reconfigurable (#3664) Reviewed-by: Fei Hui <[email protected]> Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit c0f405a)
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…de-slow-nodes.enabled reconfigurable (apache#3664) Reviewed-by: Fei Hui <[email protected]> Signed-off-by: Akira Ajisaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Consider that make dfs.namenode.block-placement-policy.exclude-slow-nodes.enabled reconfigurable and rapid rollback in case this feature HDFS-16076 unexpected things happen in production environment
Details: HDFS-16314