HADOOP-17990. Fix failing concurrent FS.initialize commands when fs.azure.createRemoteFileSystemDuringInitialization is enabled. #3620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zure.createRemoteFileSystemDuringInitialization is enabled.
|
💔 -1 overall
This message was automatically generated. |
steveloughran
requested changes
Nov 5, 2021
| if (ex instanceof AzureBlobFileSystemException) { | ||
| checkException(null, (AzureBlobFileSystemException) ex, | ||
| AzureServiceErrorCode.FILE_SYSTEM_ALREADY_EXISTS); | ||
| } else if (ex.getCause() != null && ex.getCause() instanceof AzureBlobFileSystemException) { |
Contributor
There was a problem hiding this comment.
instanceof always returns false if source is null, so the null check here can be removed
| try { | ||
| this.createFileSystem(tracingContext); | ||
| } catch (IOException ex) { | ||
| if (ex instanceof AzureBlobFileSystemException) { |
Contributor
There was a problem hiding this comment.
better to add a catch(AzureBlobFileSystemException) clause
|
|
||
| @Test | ||
| public void ensureFilesystemWillBeCreatedIfCreationConfigIsSet() throws Exception { | ||
| final AzureBlobFileSystem fs = createFileSystem(); |
Contributor
There was a problem hiding this comment.
use try with resources to close afterwards
| final MockAzureBlobFileSystemStore store = new MockAzureBlobFileSystemStore(config); | ||
| fs.setAbfsStore(store); | ||
| fs.createFileSystemIfNotExist(getTestTracingContext(fs, true)); | ||
| assert(store.isCreateFileSystemCalled); |
Contributor
There was a problem hiding this comment.
assertj assertions with useful error text
Contributor
|
had a quick look at the code
example #3611 (comment) |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
Thanks for the review, I have addressed the commets.
Test result output |
Contributor
Author
|
I saw this compilation error coming from Yetus, is this expected? |
Contributor
|
yetus has been a bit flaky recently (I managed to break trunk & 3.3; some docker image/openssl issues, but these seem new) style |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
When fs.azure.createRemoteFileSystemDuringInitialization is enabled, the filesystem will create a container if it does not already exist inside the initialize method. The current flow of creating the container will fail in the case of concurrent initialize methods being executed simultaneously (only one request can create the container, the rest will fail instead of moving on). This PR is fixing this issue by also catching org.apache.Hadoop.fs.FileAlreadyExistsException generated by the createFilesystem command.
How was this patch tested?
A new test in ITestAzureBlobFileSystemInitAndCreate is introduced which was breaking before the fox.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?