HDFS-16300. Use libcrypto in Windows for libhdfspp#3617
Merged
goiri merged 3 commits intoapache:trunkfrom Nov 4, 2021
Merged
Conversation
|
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Nov 4, 2021
|
💔 -1 overall
This message was automatically generated. |
GauthamBanasandra
added a commit
that referenced
this pull request
Nov 7, 2021
This reverts commit 1032724.
GauthamBanasandra
added a commit
to GauthamBanasandra/hadoop
that referenced
this pull request
Nov 7, 2021
…)" This reverts commit 1032724.
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Currently, eay32 is the library that's used in libhdfspp for Windows. Whereas, we use libcrypto for the rest of the platforms. As per the following mail thread, the OpenSSL library was renamed from eay32 to libcrypto from OpenSSL version 1.1.0 onwards - https://mta.openssl.org/pipermail/openssl-dev/2016-August/008351.html.
Thus, we need to use libcrypto on Windows as well to ensure that we standardize the version of the OpenSSL libraries used across platforms.
How was this patch tested?
Build passed on Windows (using stubs for those parts that don't compile yet) - https://issues.apache.org/jira/secure/attachment/13035697/build-log-hdfs-nacl-windows-10.log
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?