Skip to content

HDFS-16300. Use libcrypto in Windows for libhdfspp#3617

Merged
goiri merged 3 commits intoapache:trunkfrom
GauthamBanasandra:rem-eay32
Nov 4, 2021
Merged

HDFS-16300. Use libcrypto in Windows for libhdfspp#3617
goiri merged 3 commits intoapache:trunkfrom
GauthamBanasandra:rem-eay32

Conversation

@GauthamBanasandra
Copy link
Copy Markdown
Member

Description of PR

Currently, eay32 is the library that's used in libhdfspp for Windows. Whereas, we use libcrypto for the rest of the platforms. As per the following mail thread, the OpenSSL library was renamed from eay32 to libcrypto from OpenSSL version 1.1.0 onwards - https://mta.openssl.org/pipermail/openssl-dev/2016-August/008351.html.

Thus, we need to use libcrypto on Windows as well to ensure that we standardize the version of the OpenSSL libraries used across platforms.

How was this patch tested?

Build passed on Windows (using stubs for those parts that don't compile yet) - https://issues.apache.org/jira/secure/attachment/13035697/build-log-hdfs-nacl-windows-10.log

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link
Copy Markdown

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 35m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 34m 40s trunk passed
+1 💚 compile 2m 51s trunk passed
+1 💚 mvnsite 0m 29s trunk passed
+1 💚 shadedclient 56m 24s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 17s the patch passed
+1 💚 compile 2m 40s the patch passed
+1 💚 cc 2m 40s the patch passed
+1 💚 golang 2m 40s the patch passed
+1 💚 javac 2m 40s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 21s the patch passed
+1 💚 shadedclient 18m 18s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 31m 33s hadoop-hdfs-native-client in the patch passed.
+1 💚 asflicense 0m 38s The patch does not generate ASF License warnings.
147m 57s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3617/1/artifact/out/Dockerfile
GITHUB PR #3617
Optional Tests dupname asflicense compile cc mvnsite javac unit codespell golang
uname Linux a6a5521f94fc 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 2b258c4
Default Java Red Hat, Inc.-1.8.0_312-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3617/1/testReport/
Max. process+thread count 634 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3617/1/console
versions git=2.9.5 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@goiri goiri merged commit 1032724 into apache:trunk Nov 4, 2021
@GauthamBanasandra GauthamBanasandra deleted the rem-eay32 branch November 4, 2021 16:20
@hadoop-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 20m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
-1 ❌ mvninstall 21m 33s /branch-mvninstall-root.txt root in trunk failed.
+1 💚 compile 3m 6s trunk passed
+1 💚 mvnsite 0m 46s trunk passed
+1 💚 shadedclient 44m 2s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 24s the patch passed
+1 💚 compile 2m 50s the patch passed
+1 💚 cc 2m 50s the patch passed
+1 💚 golang 2m 50s the patch passed
+1 💚 javac 2m 50s the patch passed
+1 💚 blanks 0m 1s The patch has no blanks issues.
+1 💚 mvnsite 0m 27s the patch passed
+1 💚 shadedclient 18m 34s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 32m 15s hadoop-hdfs-native-client in the patch passed.
+1 💚 asflicense 0m 48s The patch does not generate ASF License warnings.
122m 23s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3617/1/artifact/out/Dockerfile
GITHUB PR #3617
Optional Tests dupname asflicense compile cc mvnsite javac unit codespell golang
uname Linux 65e58a06339f 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 2b258c4
Default Java Red Hat, Inc.-1.8.0_312-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3617/1/testReport/
Max. process+thread count 638 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3617/1/console
versions git=2.27.0 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

GauthamBanasandra added a commit that referenced this pull request Nov 7, 2021
GauthamBanasandra added a commit to GauthamBanasandra/hadoop that referenced this pull request Nov 7, 2021
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants