HADOOP-13617 : Retry requests with updated authentication #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelmerk
changed the title
jelmerk
force-pushed
the
HADOOP_13617
branch
4 times, most recently
from
ceb94ad to
3fa373d
Compare
jelmerk
changed the title
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
This change allows user to register the metrics on the per-container basis. Tested in beam runner and works as expected. Author: xiliu <[email protected]> Reviewers: Prateek Maheshwari <[email protected]> Closes apache#361 from xinyuiscool/SAMZA-1504
Contributor
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started using hadoop's openstack filesystem (Swift) as a storage backend for Apache Flink and ran into the problem that every few hours an error would be triggered that would cause our flink jobs to get restarted.
The problem happens when the token that is used to make api calls expires. At that point the server will return a 401 status code (unauthorized).
What should happen next is that the token should be refreshed and the request should be retried with the new token.
But what happens is that while a new token is requested , the request is retried with the old token and will always fail.
The fix is a simple one, set the correct authentication header on the request before retrying
It turns out that this issue had already been reported in 2016 and a patch was provided by the original reporter.
However for some reason the patch was never merged.
Because the code has changed a bit since the patch was created, i took the liberty of adapting it so it compiles cleanly on the current trunk. I also removed the test the original author created because it basically did a sleep until a token expired. (which usually takes hours)