HDFS-16294.Remove invalid DataNode#CONFIG_PROPERTY_SIMULATED.#3605
Merged
tasanuma merged 1 commit intoapache:trunkfrom Nov 4, 2021
Merged
HDFS-16294.Remove invalid DataNode#CONFIG_PROPERTY_SIMULATED.#3605tasanuma merged 1 commit intoapache:trunkfrom
tasanuma merged 1 commit intoapache:trunkfrom
Conversation
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
It seems that Jenkins did not execute successfully, It seems that these have little to do with the code I submitted. |
tasanuma
approved these changes
Nov 4, 2021
Member
tasanuma
left a comment
There was a problem hiding this comment.
LGTM. I don't think the unit test is required, so the result of Jenkins is not a problem.
Member
|
@jianghuazhu Thanks for your contribution. |
tasanuma
pushed a commit
that referenced
this pull request
Nov 4, 2021
(cherry picked from commit 72718a8)
tasanuma
pushed a commit
that referenced
this pull request
Nov 4, 2021
(cherry picked from commit 72718a8)
tasanuma
pushed a commit
that referenced
this pull request
Nov 4, 2021
(cherry picked from commit 72718a8)
Contributor
Author
|
Thank you very much. @tasanuma |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
As early as when HDFS-2907 was resolved, SimulatedFSDataset#CONFIG_PROPERTY_SIMULATED was removed. Replaced by: SimulatedFSDataset#Factory and DFSConfigKyes#DFS_DATANODE_FSDATASET_FACTORY_KEY.
However, the introduction to CONFIG_PROPERTY_SIMULATED is still retained in the DataNode.
Details: HDFS-16294
How was this patch tested?
This pr mainly solves the changes related to annotations, and the test pressure is not great.