Skip to content

HDFS-16294.Remove invalid DataNode#CONFIG_PROPERTY_SIMULATED.#3605

Merged
tasanuma merged 1 commit intoapache:trunkfrom
jianghuazhu:HDFS-16294
Nov 4, 2021
Merged

HDFS-16294.Remove invalid DataNode#CONFIG_PROPERTY_SIMULATED.#3605
tasanuma merged 1 commit intoapache:trunkfrom
jianghuazhu:HDFS-16294

Conversation

@jianghuazhu
Copy link
Copy Markdown
Contributor

Description of PR

As early as when HDFS-2907 was resolved, SimulatedFSDataset#CONFIG_PROPERTY_SIMULATED was removed. Replaced by: SimulatedFSDataset#Factory and DFSConfigKyes#DFS_DATANODE_FSDATASET_FACTORY_KEY.
However, the introduction to CONFIG_PROPERTY_SIMULATED is still retained in the DataNode.
Details: HDFS-16294

How was this patch tested?

This pr mainly solves the changes related to annotations, and the test pressure is not great.

@hadoop-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 31m 57s trunk passed
+1 💚 compile 1m 23s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 1m 16s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 1m 0s trunk passed
+1 💚 mvnsite 1m 23s trunk passed
+1 💚 javadoc 0m 58s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 1m 24s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 3m 6s trunk passed
+1 💚 shadedclient 22m 4s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 11s the patch passed
+1 💚 compile 1m 13s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 1m 13s the patch passed
+1 💚 compile 1m 5s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 1m 5s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 50s the patch passed
+1 💚 mvnsite 1m 12s the patch passed
+1 💚 javadoc 0m 45s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 1m 21s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 3m 6s the patch passed
+1 💚 shadedclient 21m 43s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 223m 16s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 46s The patch does not generate ASF License warnings.
319m 45s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3605/1/artifact/out/Dockerfile
GITHUB PR #3605
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux e0355e340cb5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / d46bd52
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3605/1/testReport/
Max. process+thread count 3390 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3605/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@jianghuazhu
Copy link
Copy Markdown
Contributor Author

It seems that Jenkins did not execute successfully, It seems that these have little to do with the code I submitted.
@tasanuma @prasad-acit @tomscut, you are willing to spend some time reviewing this PR.
Thank you very much.

Copy link
Copy Markdown
Member

@tasanuma tasanuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't think the unit test is required, so the result of Jenkins is not a problem.

@tasanuma tasanuma merged commit 72718a8 into apache:trunk Nov 4, 2021
@tasanuma
Copy link
Copy Markdown
Member

tasanuma commented Nov 4, 2021

@jianghuazhu Thanks for your contribution.

tasanuma pushed a commit that referenced this pull request Nov 4, 2021
tasanuma pushed a commit that referenced this pull request Nov 4, 2021
tasanuma pushed a commit that referenced this pull request Nov 4, 2021
@jianghuazhu
Copy link
Copy Markdown
Contributor Author

Thank you very much. @tasanuma

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants