HDFS-16291.Make the comment of INode#ReclaimContext more standardized. by jianghuazhu · Pull Request #3602 · apache/hadoop

jianghuazhu · 2021-10-31T13:18:53Z

Description of PR

In the INode#ReclaimContext class, there are some irregular comments.
The purpose of this pr is to make them more standardized.
Details: HDFS-16291

How was this patch tested?

Here is just some work on the documentation, the test pressure is not great.

hadoop-yetus · 2021-10-31T20:59:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 56s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	35m 17s		trunk passed
+1 💚	compile	1m 23s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	1m 14s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	0m 59s		trunk passed
+1 💚	mvnsite	1m 21s		trunk passed
+1 💚	javadoc	0m 55s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 27s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	3m 15s		trunk passed
+1 💚	shadedclient	25m 6s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 13s		the patch passed
+1 💚	compile	1m 18s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	1m 18s		the patch passed
+1 💚	compile	1m 8s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	1m 8s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 54s		the patch passed
+1 💚	mvnsite	1m 15s		the patch passed
+1 💚	javadoc	0m 47s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 19s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	3m 20s		the patch passed
+1 💚	shadedclient	25m 20s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	352m 49s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 40s		The patch does not generate ASF License warnings.
		459m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3602/1/artifact/out/Dockerfile
GITHUB PR	#3602
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 475888c7d128 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 89a6347517792d0f8e9c302b4f8cdbfad211cfee
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3602/1/testReport/
Max. process+thread count	1981 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3602/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

jianghuazhu · 2021-11-01T05:20:51Z

It seems that Jenkins did not execute successfully. It seems that these have little to do with the code I submitted.
@ayushtkn @virajjasani @tomscut, you are willing to spend some time reviewing this PR.
Thank you very much.

jianghuazhu · 2021-11-01T16:15:42Z

Thank you @tomscut for your comments and reviews.

jianghuazhu · 2021-11-02T11:09:58Z

Hi @jojochuang @ferhui @Hexiaoqiao, are you willing to spend some time to help review this pr.
Thank you very much.

ferhui

Thanks for ping me, minor comments

hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java

virajjasani

+1 (non-binding)

jianghuazhu · 2021-11-03T08:49:06Z

Thank you very much. @ferhui @virajjasani

hadoop-yetus · 2021-11-03T14:55:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 56s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 2s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	35m 13s		trunk passed
+1 💚	compile	1m 22s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	1m 15s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	1m 2s		trunk passed
+1 💚	mvnsite	1m 22s		trunk passed
+1 💚	javadoc	0m 57s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 26s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	3m 15s		trunk passed
+1 💚	shadedclient	25m 3s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 15s		the patch passed
+1 💚	compile	1m 17s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	1m 17s		the patch passed
+1 💚	compile	1m 10s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	1m 10s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 54s		the patch passed
+1 💚	mvnsite	1m 14s		the patch passed
+1 💚	javadoc	0m 47s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 17s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	3m 19s		the patch passed
+1 💚	shadedclient	26m 58s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	348m 51s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		457m 26s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestHDFSFileSystemContract

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3602/2/artifact/out/Dockerfile
GITHUB PR	#3602
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 5d5d26c42b34 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `673f55d`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3602/2/testReport/
Max. process+thread count	1906 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3602/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

ferhui · 2021-11-04T01:52:43Z

@jianghuazhu Thanks for contribution. @virajjasani @tomscut Thanks for review! Merged

apache#3602)

tomscut approved these changes Nov 1, 2021

View reviewed changes

ferhui reviewed Nov 3, 2021

View reviewed changes

hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java Outdated Show resolved Hide resolved

HDFS-16291.Make the comment of INode#ReclaimContext more standardized.

673f55d

jianghuazhu force-pushed the HDFS-16291 branch from 89a6347 to 673f55d Compare November 3, 2021 07:17

ferhui approved these changes Nov 3, 2021

View reviewed changes

virajjasani approved these changes Nov 3, 2021

View reviewed changes

ferhui merged commit 18b2cca into apache:trunk Nov 4, 2021

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022

HDFS-16291.Make the comment of INode#ReclaimContext more standardized. (

5cff1bd

apache#3602)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDFS-16291.Make the comment of INode#ReclaimContext more standardized.#3602

HDFS-16291.Make the comment of INode#ReclaimContext more standardized.#3602
ferhui merged 1 commit intoapache:trunkfrom
jianghuazhu:HDFS-16291

jianghuazhu commented Oct 31, 2021

Uh oh!

hadoop-yetus commented Oct 31, 2021

Uh oh!

jianghuazhu commented Nov 1, 2021

Uh oh!

jianghuazhu commented Nov 1, 2021

Uh oh!

jianghuazhu commented Nov 2, 2021

Uh oh!

ferhui left a comment

Uh oh!

Uh oh!

virajjasani left a comment •

edited

Loading

Uh oh!

jianghuazhu commented Nov 3, 2021

Uh oh!

hadoop-yetus commented Nov 3, 2021

Uh oh!

ferhui commented Nov 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

jianghuazhu commented Oct 31, 2021

Description of PR

How was this patch tested?

Uh oh!

hadoop-yetus commented Oct 31, 2021

Uh oh!

jianghuazhu commented Nov 1, 2021

Uh oh!

jianghuazhu commented Nov 1, 2021

Uh oh!

jianghuazhu commented Nov 2, 2021

Uh oh!

ferhui left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

virajjasani left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jianghuazhu commented Nov 3, 2021

Uh oh!

hadoop-yetus commented Nov 3, 2021

Uh oh!

ferhui commented Nov 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

virajjasani left a comment •

edited

Loading