Skip to content

HADOOP-17971. Exclude IBM Java security classes from being shaded/relocated.#3567

Merged
aajisaka merged 3 commits intoapache:trunkfrom
n-marion:HADOOP-17971_exclude-ibm-security
Oct 20, 2021
Merged

HADOOP-17971. Exclude IBM Java security classes from being shaded/relocated.#3567
aajisaka merged 3 commits intoapache:trunkfrom
n-marion:HADOOP-17971_exclude-ibm-security

Conversation

@n-marion
Copy link
Copy Markdown
Contributor

Description of PR

Exclude IBM Java security classes located in com.ibm.security* from being shaded.

How was this patch tested?

Manual injection of UserGroupInformation class files (which contain references to com.ibm.security classes) that were compiled manually.

I followed bug fixes for similar issues. IBM java isn't actually used in source code except being referenced when it is the running JVM.

@hadoop-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 12m 11s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 12m 48s Maven dependency ordering for branch
+1 💚 mvninstall 20m 59s trunk passed
+1 💚 compile 0m 24s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 0m 25s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 mvnsite 1m 18s trunk passed
+1 💚 javadoc 1m 12s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 1m 12s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 shadedclient 56m 42s branch has no errors when building and testing our client artifacts.
-0 ⚠️ patch 57m 1s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 28s Maven dependency ordering for patch
+1 💚 mvninstall 9m 57s the patch passed
+1 💚 compile 0m 15s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 0m 15s the patch passed
+1 💚 compile 0m 16s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 0m 16s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 49s the patch passed
+1 💚 xml 0m 4s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 46s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 45s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 shadedclient 20m 26s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 19s hadoop-client-api in the patch passed.
+1 💚 unit 0m 19s hadoop-client-runtime in the patch passed.
+1 💚 unit 0m 19s hadoop-client-minicluster in the patch passed.
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
104m 10s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3567/1/artifact/out/Dockerfile
GITHUB PR #3567
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml
uname Linux 650fc9995833 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 2133274
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3567/1/testReport/
Max. process+thread count 661 (vs. ulimit of 5500)
modules C: hadoop-client-modules/hadoop-client-api hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster U: hadoop-client-modules
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3567/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Copy link
Copy Markdown
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I haven't tested with IBM Java, however, given com.sun.security.* packages are excluded, com.ibm.security.* packages should be excluded as well. Thank you @n-marion

@aajisaka aajisaka merged commit 3e11354 into apache:trunk Oct 20, 2021
aajisaka pushed a commit that referenced this pull request Oct 20, 2021
…ocated. (#3567)

Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
(cherry picked from commit 3e11354)
aajisaka pushed a commit that referenced this pull request Oct 20, 2021
…ocated. (#3567)

Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
(cherry picked from commit 3e11354)
aajisaka pushed a commit that referenced this pull request Oct 20, 2021
…ocated. (#3567)

Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
(cherry picked from commit 3e11354)
(cherry picked from commit 87869c6)
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
…ocated. (apache#3567)

Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants