HADOOP-17970. unguava: remove Preconditions from hdfs-projects modules#3566
Merged
amahussein merged 1 commit intoapache:trunkfrom Oct 23, 2021
Merged
HADOOP-17970. unguava: remove Preconditions from hdfs-projects modules#3566amahussein merged 1 commit intoapache:trunkfrom
amahussein merged 1 commit intoapache:trunkfrom
Conversation
|
💔 -1 overall
This message was automatically generated. |
amahussein
force-pushed
the
amahadoop-17110-17970
branch
from
fe79eb3 to
ed0c8aa
Compare
amahussein
force-pushed
the
amahadoop-17110-17970
branch
from
ed0c8aa to
e96b2ac
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
@virajjasani , Can you please take a look at the changes? |
Contributor
Author
|
Thanks @virajjasani |
Member
|
@amahussein you shouldn't merge your own patch before getting binding +1 |
aajisaka
reviewed
Jul 10, 2022
Member
aajisaka
left a comment
aajisaka
left a comment
There was a problem hiding this comment.
My late +1, thank you @amahussein and @virajjasani
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
prabhjyotsingh
pushed a commit
to acceldata-io/hadoop
that referenced
this pull request
Mar 11, 2026
kravii
pushed a commit
to acceldata-io/hadoop
that referenced
this pull request
Mar 18, 2026
* HADOOP-17970. unguava: remove Preconditions from hdfs-projects modules (apache#3566) * HDFS-16616. remove use of org.apache.hadoop.util.Sets (apache#4400) Co-Authored by: Samrat Deb # Conflicts: # hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterUserMappings.java # hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java # hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNodeSyncer.java # hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java # hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolManager.java # hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/sps/metrics/ExternalSPSBeanMetrics.java # hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java # hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/net/TestDFSNetworkTopology.java # hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/client/TestQJMWithFaults.java # hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestRefreshUserMappings.java * HADOOP-17123. remove guava Preconditions from Hadoop-common-project modules (apache#3543) * HDFS-13695. Move logging to slf4j in HDFS package. Contributed by Ian Pickering. * HADOOP-18957. Use StandardCharsets.UTF_8 (apache#6231). Contributed by PJ Fanning. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org> * HDFS-13695. Move logging to slf4j in HDFS package. Contributed by Ian Pickering. Giovanni Matteo Fumarola 09/06/2018 05:48 PM @ Conflicts: @ hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/QueueCLI.java * ODP-6204: Resolve dependency conflict --------- Signed-off-by: Ayush Saxena <ayushsaxena@apache.org> Co-authored-by: Ahmed Hussein <50450311+amahussein@users.noreply.github.com> Co-authored-by: Giovanni Matteo Fumarola <gifuma@apache.org>
prabhjyotsingh
pushed a commit
to acceldata-io/hadoop
that referenced
this pull request
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Replace
guava.Preconditionsin folderhadoop-hdfs-projectwithhadoop.util.PreconditionsHow was this patch tested?
Ran the tests locally
For code changes:
checkPositionIndex. Since there were only 4 occurrences I preferred to inline them in the code. The tradeoff is a slight change of behavior as guava.Preconditions.checkPositionIndex may throwIllegalArgumentException, while the inlined version only throwsIndexOutOfBoundsException