Skip to content

HDFS-16279. Print detail datanode info when process first storage report#3564

Merged
tasanuma merged 4 commits intoapache:trunkfrom
tomscut:HDFS-16279
Oct 29, 2021
Merged

HDFS-16279. Print detail datanode info when process first storage report#3564
tasanuma merged 4 commits intoapache:trunkfrom
tomscut:HDFS-16279

Conversation

@tomscut
Copy link
Copy Markdown
Contributor

@tomscut tomscut commented Oct 19, 2021

JIRA: HDFS-16279

Print detail datanode info when process first storage report.

image

@hadoop-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 16m 49s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 34m 3s trunk passed
+1 💚 compile 1m 21s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 1m 13s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 1m 0s trunk passed
+1 💚 mvnsite 1m 22s trunk passed
+1 💚 javadoc 0m 55s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 1m 27s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 3m 18s trunk passed
+1 💚 shadedclient 24m 17s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 13s the patch passed
+1 💚 compile 1m 19s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 1m 19s the patch passed
+1 💚 compile 1m 7s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 1m 7s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 52s the patch passed
+1 💚 mvnsite 1m 15s the patch passed
+1 💚 javadoc 0m 48s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 1m 20s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 3m 22s the patch passed
+1 💚 shadedclient 23m 56s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 328m 49s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
447m 46s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3564/1/artifact/out/Dockerfile
GITHUB PR #3564
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux c253f97aba3e 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 7cf5b29
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3564/1/testReport/
Max. process+thread count 2024 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3564/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@tomscut
Copy link
Copy Markdown
Contributor Author

tomscut commented Oct 20, 2021

Hi @ayushtkn @tasanuma @aajisaka @ferhui , please help review this simple modification. Thanks.

@aajisaka
Copy link
Copy Markdown
Member

My understanding is that the change is to print <datanode IP addr>:<port> instead of the UUID of the datanode. I think it is a good change because the UUID is rarely used in troubleshooting. How about printing the hostname instead of the IP address?

@tomscut
Copy link
Copy Markdown
Contributor Author

tomscut commented Oct 20, 2021

My understanding is that the change is to print <datanode IP addr>:<port> instead of the UUID of the datanode. I think it is a good change because the UUID is rarely used in troubleshooting. How about printing the hostname instead of the IP address?

Thanks for your good suggestion. Hostname is a better choice. I will change it to nodeID.getXferAddrWithHostname().

@hadoop-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 12s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 40m 18s trunk passed
+1 💚 compile 1m 47s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 1m 35s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 1m 11s trunk passed
+1 💚 mvnsite 1m 48s trunk passed
+1 💚 javadoc 1m 16s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 1m 47s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 4m 6s trunk passed
+1 💚 shadedclient 29m 11s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 32s the patch passed
+1 💚 compile 1m 39s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 1m 39s the patch passed
+1 💚 compile 1m 28s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 1m 28s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 3s the patch passed
+1 💚 mvnsite 1m 31s the patch passed
+1 💚 javadoc 1m 2s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 1m 36s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 4m 14s the patch passed
+1 💚 shadedclient 30m 4s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 332m 32s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 36s The patch does not generate ASF License warnings.
457m 48s
Reason Tests
Failed junit tests hadoop.fs.viewfs.TestViewFSOverloadSchemeWithMountTableConfigInHDFS
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3564/2/artifact/out/Dockerfile
GITHUB PR #3564
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 14cb9dfb71a2 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 9ea2416
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3564/2/testReport/
Max. process+thread count 1910 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3564/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@tomscut
Copy link
Copy Markdown
Contributor Author

tomscut commented Oct 22, 2021

Hi @aajisaka , please take a look at this. Thank you.

@tomscut
Copy link
Copy Markdown
Contributor Author

tomscut commented Oct 26, 2021

Hi @jojochuang @ayushtkn @tasanuma , could you please take a look at this. Thanks.

@ferhui
Copy link
Copy Markdown
Contributor

ferhui commented Oct 26, 2021

@tomscut I think you miss the following line. Please take a look.

@tomscut
Copy link
Copy Markdown
Contributor Author

tomscut commented Oct 26, 2021

@tomscut I think you miss the following line. Please take a look.

Thanks @ferhui for reminding me. I fixed it.

@tasanuma
Copy link
Copy Markdown
Member

DatanodeID object has a lot of information. This change seems to reduce it.

Before:

java.io.IOException: ProcessReport from dead or unregistered node: DatanodeRegistration(127.0.0.1:60414, datanodeUuid=08d6a9ae-936b-44cc-8151-b10f3ecb0639, infoPort=60416, infoSecurePort=0, ipcPort=60417, storageInfo=lv=-57;cid=testClusterID;nsid=97526889;c=1635265757992)

After:

java.io.IOException: ProcessReport from dead or unregistered node: 127.0.0.1:60435

@hadoop-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 12s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 38m 6s trunk passed
+1 💚 compile 1m 44s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 1m 27s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 1m 7s trunk passed
+1 💚 mvnsite 1m 35s trunk passed
+1 💚 javadoc 1m 10s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 1m 44s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 3m 40s trunk passed
+1 💚 shadedclient 28m 41s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 28s the patch passed
+1 💚 compile 1m 36s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 1m 36s the patch passed
+1 💚 compile 1m 24s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 1m 24s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 1s the patch passed
+1 💚 mvnsite 2m 2s the patch passed
+1 💚 javadoc 1m 0s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 1m 29s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 4m 1s the patch passed
+1 💚 shadedclient 28m 28s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 328m 21s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 39s The patch does not generate ASF License warnings.
449m 18s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3564/3/artifact/out/Dockerfile
GITHUB PR #3564
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux b73d01a6e6e3 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / a63addc
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3564/3/testReport/
Max. process+thread count 1973 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3564/3/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@tomscut
Copy link
Copy Markdown
Contributor Author

tomscut commented Oct 27, 2021

ProcessReport from dead or unregistered node

Thanks @tasanuma for your comment and pointing out this issue.

When the instantiation of DatanodeID is DatanodeRegistration, it overrides toString(), so the output is a lot, but the address is IP:port.

When the nodeID instantiation object is a DatanodeDescriptor, it doesn't override the toString() method, so the output is very little, just the address IP:port.

I intended to print hostname:port as @aajisaka suggested. But there's something wrong with my implementation. I'll leave the DN address format as it was: IP:port (because changing the toString() of the datanodeID or DatanodeRegistration might cause other compatibility issues). What do you think of this way? Thank you.

@tasanuma
Copy link
Copy Markdown
Member

@tomscut Thanks for the explanation. When nodeID is DatanodeRegistration (I think it is most likely case), DatanodeRegistration#toString() is most informative.

nodeID.getDatanodeUuid():

BLOCK* processReport 0x51eb6427619ccf8f: Processing first storage report for DS-ced48a3c-7e37-4a94-9cf9-404e07e659a7 from datanode a7a8fd2f-e0cd-40a4-8fcd-65760b6bc6e6

nodeID.getXferAddrWithHostname():

BLOCK* processReport 0x5006fb6a4251db51: Processing first storage report for DS-ced48a3c-7e37-4a94-9cf9-404e07e659a7 from datanode hostname:11001

nodeID:

BLOCK* processReport 0xe518c3bd634f15e6: Processing first storage report for DS-0048bf1d-84da-444c-8c3f-251dab39f1dc from datanode DatanodeRegistration(127.0.0.1:11000, datanodeUuid=64886279-5799-47a6-96ba-653e3675e816, infoPort=11020, infoSecurePort=0, ipcPort=11010, storageInfo=lv=-57;cid=CID-130467d5-c200-4869-9330-d9eedf4f3909;nsid=930729152;c=1635316881247)

So just using nodeID looks good to me.

because changing the toString() of the datanodeID or DatanodeRegistration might cause other compatibility issues.

I agreed. Let's keep it as it was.

Copy link
Copy Markdown
Member

@tasanuma tasanuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, pending Jenkins.

@tomscut
Copy link
Copy Markdown
Contributor Author

tomscut commented Oct 27, 2021

+1, pending Jenkins.

Thanks @tasanuma for your review and comments.

@hadoop-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 51s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 34m 47s trunk passed
+1 💚 compile 1m 22s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 1m 13s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 1m 0s trunk passed
+1 💚 mvnsite 1m 21s trunk passed
+1 💚 javadoc 0m 57s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 1m 25s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 3m 18s trunk passed
+1 💚 shadedclient 25m 3s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 12s the patch passed
+1 💚 compile 1m 17s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 1m 17s the patch passed
+1 💚 compile 1m 7s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 1m 7s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 52s the patch passed
+1 💚 mvnsite 1m 16s the patch passed
+1 💚 javadoc 0m 47s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 1m 19s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 3m 22s the patch passed
+1 💚 shadedclient 24m 30s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 332m 13s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 39s The patch does not generate ASF License warnings.
437m 11s
Reason Tests
Failed junit tests hadoop.hdfs.server.mover.TestMover
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3564/4/artifact/out/Dockerfile
GITHUB PR #3564
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 2e8d77a878ae 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 275f817
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3564/4/testReport/
Max. process+thread count 1905 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3564/4/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Copy link
Copy Markdown
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ferhui @tasanuma @tomscut for your discussion and the update. LGTM.

@tomscut
Copy link
Copy Markdown
Contributor Author

tomscut commented Oct 28, 2021

Thank you @ferhui @tasanuma @tomscut for your discussion and the update. LGTM.

Thanks @aajisaka for reviewing again.

@tasanuma tasanuma merged commit 6aa664c into apache:trunk Oct 29, 2021
@tasanuma
Copy link
Copy Markdown
Member

Merged. Thanks for your contribution, @tomscut. Thanks for your review and discussion, @aajisaka and @ferhui.

tasanuma pushed a commit that referenced this pull request Oct 29, 2021
tasanuma pushed a commit that referenced this pull request Oct 29, 2021
@tomscut
Copy link
Copy Markdown
Contributor Author

tomscut commented Oct 29, 2021

Thanks @tasanuma @aajisaka @ferhui for your review and kind suggestions.

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants