HDFS-16263. Add CMakeLists for hdfs_allowSnapshot by GauthamBanasandra · Pull Request #3531 · apache/hadoop

GauthamBanasandra · 2021-10-07T19:27:50Z

Description of PR

Currently, hdfs_allowSnapshot
is built in it's parent directory's
CMakeLists.txt. * Need to move this into a separate
CMakeLists.txt file under
hdfs-allow-snapshot so that it's
more modular.

How was this patch tested?

Unit tests ran successfully.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

* Currently, hdfs_allowSnapshot is built in it's parent directory's CMakeLists.txt. * Need to move this into a separate CMakeLists.txt file under hdfs-allow-snapshot so that it's more modular.

This reverts commit 603b3b5.

hadoop-yetus · 2021-10-07T21:23:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 54s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 26s		trunk passed
+1 💚	compile	3m 0s		trunk passed
+1 💚	mvnsite	0m 24s		trunk passed
+1 💚	shadedclient	56m 1s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 15s		the patch passed
+1 💚	compile	2m 36s		the patch passed
+1 💚	cc	2m 36s		the patch passed
+1 💚	golang	2m 36s		the patch passed
+1 💚	javac	2m 36s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 18s		the patch passed
+1 💚	shadedclient	17m 54s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	33m 54s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 33s		The patch does not generate ASF License warnings.
		114m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3531/1/artifact/out/Dockerfile
GITHUB PR	#3531
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell golang
uname	Linux d803562655aa 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `4c53fb6`
Default Java	Red Hat, Inc.-1.8.0_302-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3531/1/testReport/
Max. process+thread count	598 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3531/1/console
versions	git=2.9.5 maven=3.6.3
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-10-07T23:47:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	24m 31s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	24m 49s		trunk passed
+1 💚	compile	3m 11s		trunk passed
+1 💚	mvnsite	0m 41s		trunk passed
+1 💚	shadedclient	50m 17s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 25s		the patch passed
+1 💚	compile	2m 44s		the patch passed
+1 💚	cc	2m 44s		the patch passed
+1 💚	golang	2m 44s		the patch passed
+1 💚	javac	2m 44s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 30s		the patch passed
+1 💚	shadedclient	21m 3s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	40m 26s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 47s		The patch does not generate ASF License warnings.
		143m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3531/1/artifact/out/Dockerfile
GITHUB PR	#3531
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell golang
uname	Linux 0c1817a8aa55 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `4c53fb6`
Default Java	Red Hat, Inc.-1.8.0_302-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3531/1/testReport/
Max. process+thread count	615 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3531/1/console
versions	git=2.27.0 maven=3.6.3
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-10-08T02:05:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	12m 27s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	28m 37s		trunk passed
+1 💚	compile	2m 46s		trunk passed
+1 💚	mvnsite	0m 27s		trunk passed
+1 💚	shadedclient	59m 18s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 17s		the patch passed
+1 💚	compile	2m 42s		the patch passed
+1 💚	cc	2m 42s		the patch passed
+1 💚	golang	2m 42s		the patch passed
+1 💚	javac	2m 42s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 34s		the patch passed
+1 💚	shadedclient	27m 57s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	31m 33s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 36s		The patch does not generate ASF License warnings.
		137m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3531/1/artifact/out/Dockerfile
GITHUB PR	#3531
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell golang
uname	Linux 5d632eb9ad7d 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `4c53fb6`
Default Java	Debian-11.0.12+7-post-Debian-2deb10u1
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3531/1/testReport/
Max. process+thread count	747 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3531/1/console
versions	git=2.20.1 maven=3.6.0
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-10-08T03:50:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 52s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	20m 38s		trunk passed
+1 💚	compile	2m 48s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	2m 50s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	mvnsite	0m 28s		trunk passed
+1 💚	shadedclient	45m 14s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 17s		the patch passed
+1 💚	compile	2m 39s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	cc	2m 39s		the patch passed
+1 💚	golang	2m 39s		the patch passed
+1 💚	javac	2m 39s		the patch passed
+1 💚	compile	2m 44s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	cc	2m 44s		the patch passed
+1 💚	golang	2m 44s		the patch passed
+1 💚	javac	2m 44s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 20s		the patch passed
+1 💚	shadedclient	18m 13s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	31m 57s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 35s		The patch does not generate ASF License warnings.
		105m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3531/1/artifact/out/Dockerfile
GITHUB PR	#3531
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell golang
uname	Linux d2dc607cad78 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `4c53fb6`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3531/1/testReport/
Max. process+thread count	568 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3531/1/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

GauthamBanasandra added 4 commits October 8, 2021 00:53

HDFS-16263. Add CMakeLists for hdfs_allowSnapshot

7cc88c5

* Currently, hdfs_allowSnapshot is built in it's parent directory's CMakeLists.txt. * Need to move this into a separate CMakeLists.txt file under hdfs-allow-snapshot so that it's more modular.

Trigger CI

603b3b5

Revert "Trigger CI"

20fc760

This reverts commit 603b3b5.

Install allow_Snapshot target

4c53fb6

goiri approved these changes Oct 8, 2021

View reviewed changes

goiri merged commit cc95fc4 into apache:trunk Oct 8, 2021

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022

HDFS-16263. Add CMakeLists for hdfs_allowSnapshot (apache#3531)

d1e9ab2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDFS-16263. Add CMakeLists for hdfs_allowSnapshot#3531

HDFS-16263. Add CMakeLists for hdfs_allowSnapshot#3531
goiri merged 4 commits intoapache:trunkfrom
GauthamBanasandra:separate-cmake

GauthamBanasandra commented Oct 7, 2021

Uh oh!

hadoop-yetus commented Oct 7, 2021

Uh oh!

hadoop-yetus commented Oct 7, 2021

Uh oh!

hadoop-yetus commented Oct 8, 2021

Uh oh!

hadoop-yetus commented Oct 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

GauthamBanasandra commented Oct 7, 2021

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Oct 7, 2021

Uh oh!

hadoop-yetus commented Oct 7, 2021

Uh oh!

hadoop-yetus commented Oct 8, 2021

Uh oh!

hadoop-yetus commented Oct 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants