HADOOP-17930. implement non-guava Precondition checkState#3522
Merged
tasanuma merged 1 commit intoapache:trunkfrom Oct 7, 2021
Merged
HADOOP-17930. implement non-guava Precondition checkState#3522tasanuma merged 1 commit intoapache:trunkfrom
tasanuma merged 1 commit intoapache:trunkfrom
Conversation
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
@tasanuma and @virajjasani , can you please check the changes? |
virajjasani
approved these changes
Oct 6, 2021
| return CHECK_ARGUMENT_EX_MESSAGE; | ||
| } | ||
|
|
||
| /* @VisibleForTesting */ |
Contributor
There was a problem hiding this comment.
Thanks for this, I think we can catchup on this later based on which PR goes first.
Member
|
Merged it. Thanks for your contribution, @amahussein. Thanks for your review, @virajjasani. |
tasanuma
pushed a commit
that referenced
this pull request
Oct 7, 2021
Reviewed-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Takanobu Asanuma <tasanuma@apache.org> (cherry picked from commit c36f940)
tasanuma
pushed a commit
that referenced
this pull request
Oct 7, 2021
Reviewed-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Takanobu Asanuma <tasanuma@apache.org> (cherry picked from commit c36f940)
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Reviewed-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Takanobu Asanuma <tasanuma@apache.org>
shubhluck
pushed a commit
to acceldata-io/hadoop
that referenced
this pull request
Sep 4, 2025
Reviewed-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Takanobu Asanuma <tasanuma@apache.org> (cherry picked from commit c36f940)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
As part In order to replace Guava Preconditions, we need to implement our own versions of the API.
This Jira is to add the implementation
checkStateto the existing classorg.apache.hadoop.util.PreconditionsHow was this patch tested?
Extended the unit test org.apache.hadoop.util.TestPreconditions
testCheckStateWithSuccess()testCheckStateWithFailure()For code changes: