HADOOP-17932. Distcp file length comparison have no effect by adol001 · Pull Request #3519 · apache/hadoop

adol001 · 2021-10-05T02:48:21Z

Fix invocation in RetriableFileCopyCommand that's broken

hadoop-yetus · 2021-10-05T04:45:38Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	12m 42s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 45s		trunk passed
+1 💚	compile	0m 34s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	0m 32s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	0m 27s		trunk passed
+1 💚	mvnsite	0m 36s		trunk passed
+1 💚	javadoc	0m 31s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 29s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	0m 49s		trunk passed
+1 💚	shadedclient	19m 2s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 27s		the patch passed
+1 💚	compile	0m 25s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	0m 25s		the patch passed
+1 💚	compile	0m 22s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	0m 22s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 17s		the patch passed
+1 💚	mvnsite	0m 25s		the patch passed
+1 💚	javadoc	0m 20s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 19s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	0m 49s		the patch passed
+1 💚	shadedclient	18m 50s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	22m 50s	/patch-unit-hadoop-tools_hadoop-distcp.txt	hadoop-distcp in the patch passed.
+1 💚	asflicense	0m 35s		The patch does not generate ASF License warnings.
		115m 53s

Reason	Tests
Failed junit tests	hadoop.tools.mapred.TestCopyMapper
	hadoop.tools.TestDistCpSync
	hadoop.tools.mapred.TestCopyMapperCompositeCrc

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3519/1/artifact/out/Dockerfile
GITHUB PR	#3519
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux ade9bfa95c91 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `ddc7c82`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3519/1/testReport/
Max. process+thread count	674 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3519/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

jojochuang

thx for reporting the issue and providing a fix. Would it be possible to come up with a test?

jojochuang · 2021-10-05T16:32:56Z

nvm... Steve's okay w/o a test. So I'm +1

...ols/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java

…ls/mapred/RetriableFileCopyCommand.java Co-authored-by: Akira Ajisaka <aajisaka@apache.org>

hadoop-yetus · 2021-10-18T09:50:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 39s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	31m 12s		trunk passed
+1 💚	compile	0m 33s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	0m 31s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	0m 27s		trunk passed
+1 💚	mvnsite	0m 36s		trunk passed
+1 💚	javadoc	0m 31s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 28s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	0m 50s		trunk passed
+1 💚	shadedclient	18m 45s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 27s		the patch passed
+1 💚	compile	0m 26s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	0m 26s		the patch passed
+1 💚	compile	0m 22s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	0m 22s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 16s		the patch passed
+1 💚	mvnsite	0m 25s		the patch passed
+1 💚	javadoc	0m 21s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 19s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	0m 50s		the patch passed
+1 💚	shadedclient	18m 28s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	21m 26s		hadoop-distcp in the patch passed.
+1 💚	asflicense	0m 35s		The patch does not generate ASF License warnings.
		99m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3519/2/artifact/out/Dockerfile
GITHUB PR	#3519
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 3b4de3e9b602 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `a714dd7`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3519/2/testReport/
Max. process+thread count	693 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3519/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

aajisaka · 2021-10-18T10:08:12Z

Merged. Thank you @adol001 and @jojochuang

Signed-off-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit 280ae1c)

Signed-off-by: Akira Ajisaka <aajisaka@apache.org>

HADOOP-17932. Fix invocation that's broken

ddc7c82

jojochuang reviewed Oct 5, 2021

View reviewed changes

jojochuang approved these changes Oct 5, 2021

View reviewed changes

aajisaka requested changes Oct 18, 2021

View reviewed changes

...ols/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java Outdated Show resolved Hide resolved

Update hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/too…

a714dd7

…ls/mapred/RetriableFileCopyCommand.java Co-authored-by: Akira Ajisaka <aajisaka@apache.org>

aajisaka approved these changes Oct 18, 2021

View reviewed changes

aajisaka merged commit 280ae1c into apache:trunk Oct 18, 2021

aajisaka pushed a commit that referenced this pull request Oct 18, 2021

HADOOP-17932. Distcp file length comparison have no effect (#3519)

21bd015

Signed-off-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit 280ae1c)

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022

HADOOP-17932. Distcp file length comparison have no effect (apache#3519)

6b76572

Signed-off-by: Akira Ajisaka <aajisaka@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-17932. Distcp file length comparison have no effect#3519

HADOOP-17932. Distcp file length comparison have no effect#3519
aajisaka merged 2 commits intoapache:trunkfrom
adol001:distcp/HADOOP-17932-distcp-file-length-comparison-have-no-effect

adol001 commented Oct 5, 2021

Uh oh!

hadoop-yetus commented Oct 5, 2021

Uh oh!

jojochuang left a comment

Uh oh!

jojochuang commented Oct 5, 2021

Uh oh!

Uh oh!

hadoop-yetus commented Oct 18, 2021

Uh oh!

aajisaka commented Oct 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

adol001 commented Oct 5, 2021

Uh oh!

hadoop-yetus commented Oct 5, 2021

Uh oh!

jojochuang left a comment

Choose a reason for hiding this comment

Uh oh!

jojochuang commented Oct 5, 2021

Uh oh!

Uh oh!

hadoop-yetus commented Oct 18, 2021

Uh oh!

aajisaka commented Oct 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants