Skip to content

Conversation

@brumi1024
Copy link
Member

… property as a maximum when it creates dynamic queues (#3225)

Co-authored-by: Benjamin Teke [email protected]

Description of PR

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

… property as a maximum when it creates dynamic queues (apache#3225)

Co-authored-by: Benjamin Teke <[email protected]>
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 6m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 31m 13s branch-3.3 passed
+1 💚 compile 0m 54s branch-3.3 passed
+1 💚 checkstyle 0m 42s branch-3.3 passed
+1 💚 mvnsite 0m 58s branch-3.3 passed
+1 💚 javadoc 0m 43s branch-3.3 passed
+1 💚 spotbugs 1m 49s branch-3.3 passed
+1 💚 shadedclient 23m 46s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 49s the patch passed
+1 💚 compile 0m 44s the patch passed
+1 💚 javac 0m 44s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 31s /results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 100 unchanged - 1 fixed = 101 total (was 101)
+1 💚 mvnsite 0m 48s the patch passed
+1 💚 javadoc 0m 32s the patch passed
+1 💚 spotbugs 1m 48s the patch passed
+1 💚 shadedclient 23m 40s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 88m 16s hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚 asflicense 0m 34s The patch does not generate ASF License warnings.
183m 46s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3504/1/artifact/out/Dockerfile
GITHUB PR #3504
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux a43f10bd2da5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 40a07fa
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~18.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3504/1/testReport/
Max. process+thread count 831 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3504/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@szilard-nemeth szilard-nemeth changed the title YARN-10869. CS considers only the default maximum-allocation-mb/vcore… YARN-10869. CS considers only the default maximum-allocation-mb/vcore property as a maximum when it creates dynamic queues Oct 12, 2021
@szilard-nemeth szilard-nemeth merged commit 7000458 into apache:branch-3.3 Oct 12, 2021
@szilard-nemeth
Copy link
Contributor

Thanks @brumi1024 for working on this. Patch LGTM, committed to branch-3.3

symious pushed a commit to symious/hadoop that referenced this pull request Nov 21, 2024
… property as a maximum when it creates dynamic queues (apache#3504)

Co-authored-by: Benjamin Teke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants