HADOOP-17945. JsonSerialization raises EOFException reading JSON data stored on google GCS#3501
Merged
mukund-thakur merged 1 commit intoapache:trunkfrom Oct 19, 2021
Conversation
… stored on google GCS (lifted from MAPREDUCE-7341) Change-Id: I0170f311cf0a33806c21c3c50e5e797fe16b0dbf
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
@mehakmeet & @mukund-thakur could you take a quick look @ this? |
Contributor
mukund-thakur
left a comment
mukund-thakur
left a comment
There was a problem hiding this comment.
Added few questions.
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JsonSerialization.java
Show resolved
Hide resolved
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JsonSerialization.java
Show resolved
Hide resolved
| } | ||
|
|
||
| /** | ||
| * 0 byte file through the load(path, status) API will fail with an |
Contributor
There was a problem hiding this comment.
Should we add a test with 0 byte file but not passing the fileStatus.
Contributor
|
Just one test pending here then. Post that we can merge. |
Contributor
Author
|
i'm not in a setup to write tests. i don't have a work laptop and having just tried to check it out on my windows laptop, the paths for yarn timeline server are too long for the windows FS I'm not in a position to even check out the source, let alone compile it. can we take it as is? |
mukund-thakur
pushed a commit
that referenced
this pull request
Oct 19, 2021
… stored on google GCS (#3501) Contributed By: Steve Loughran
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
… stored on google GCS (apache#3501) Contributed By: Steve Loughran
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(lifted from MAPREDUCE-7341)
How was this patch tested?