Skip to content

Conversation

@tomicooler
Copy link
Contributor

…AggregationFileController#verifyAndCreateRemoteLogDir (#3355)

Co-authored-by: Tamas Domok [email protected]

Description of PR

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

…AggregationFileController#verifyAndCreateRemoteLogDir (apache#3355)

Co-authored-by: Tamas Domok <[email protected]>
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 2m 58s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.3 Compile Tests _
-1 ❌ mvninstall 5m 19s /branch-mvninstall-root.txt root in branch-3.3 failed.
+1 💚 compile 1m 8s branch-3.3 passed
+1 💚 checkstyle 0m 26s branch-3.3 passed
+1 💚 mvnsite 0m 49s branch-3.3 passed
+1 💚 javadoc 0m 49s branch-3.3 passed
+1 💚 spotbugs 1m 49s branch-3.3 passed
-1 ❌ shadedclient 5m 31s branch has errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 40s the patch passed
+1 💚 compile 0m 37s the patch passed
+1 💚 javac 0m 37s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 23s the patch passed
+1 💚 mvnsite 0m 39s the patch passed
+1 💚 javadoc 0m 44s the patch passed
+1 💚 spotbugs 1m 58s the patch passed
+1 💚 shadedclient 19m 46s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 4m 26s hadoop-yarn-common in the patch passed.
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
47m 23s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3409/1/artifact/out/Dockerfile
GITHUB PR #3409
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux d7fad058356c 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / c6ab889
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~18.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3409/1/testReport/
Max. process+thread count 511 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3409/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Change-Id: Id709e5ac73d5dc8fb593c5d404863fb294564c06
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 19s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 33m 47s branch-3.3 passed
+1 💚 compile 0m 53s branch-3.3 passed
+1 💚 checkstyle 0m 37s branch-3.3 passed
+1 💚 mvnsite 0m 59s branch-3.3 passed
+1 💚 javadoc 1m 3s branch-3.3 passed
+1 💚 spotbugs 2m 10s branch-3.3 passed
+1 💚 shadedclient 24m 17s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 40s the patch passed
+1 💚 compile 0m 36s the patch passed
+1 💚 javac 0m 36s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 23s the patch passed
+1 💚 mvnsite 0m 38s the patch passed
+1 💚 javadoc 0m 43s the patch passed
+1 💚 spotbugs 1m 59s the patch passed
+1 💚 shadedclient 19m 2s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 4m 27s hadoop-yarn-common in the patch passed.
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
92m 47s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3409/2/artifact/out/Dockerfile
GITHUB PR #3409
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 1752a99aeafe 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 59efd94
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~18.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3409/2/testReport/
Max. process+thread count 510 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3409/2/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@brumi1024 brumi1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomicooler thanks for the backport, LGTM (non-binding)

@szilard-nemeth
Copy link
Contributor

@tomicooler Thanks for working on this backport.
Latest patch LGTM, committed to branch-3.3.
Thanks @brumi1024 for the review.

@szilard-nemeth szilard-nemeth changed the title YARN-10901. Permission checking error on an existing directory in Log… YARN-10901. Permission checking error on an existing directory in LogAggregationFileController#verifyAndCreateRemoteLogDir Sep 14, 2021
@szilard-nemeth szilard-nemeth merged commit 8e4ac01 into apache:branch-3.3 Sep 14, 2021
symious pushed a commit to symious/hadoop that referenced this pull request Nov 21, 2024
…AggregationFileController#verifyAndCreateRemoteLogDir (apache#3409)

Co-authored-by: Tamas Domok <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants