-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-17563. Upgrade BouncyCastle to 1.69 #3405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
steveloughran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with this, I haven't made any changes to the modules where the tests are failing so don't know how common that is.
We will have to mark this as an incompatible change and explain about the need to upgrade ASM.
|
would it be possible to merge this? |
|
ok. should we rebase and retest? |
|
@amahussein would it be possible to rebase this? It's not a big deal but bouncycastle 1.70 is now latest version but it may not be worthwhile using that. |
|
I created #3980 just in case but can close it in favour of this. At least, we can see if 3980 build succeeds. |
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Description of PR
HADOOP-17563 . BouncyCastle to 1.69
How was this patch tested?
mvn clean install -Pdist -Dtar -DskipTests -Dmaven.javadocmvn dependency:treemvn test -Dtest=TestFileArgs,TestMultipleCachefiles,TestStreamingBadRecords,\ TestSymLink,TestMultipleArchiveFiles,TestGridmixSubmission,TestDistCacheEmulation,\ TestLoadJob,TestSleepJob,TestDistCh,TestCleanupAfterKIllFor code changes: