HDFS-16091. WebHDFS should support getSnapshotDiffReportListing. #3374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Member
Author
I filed HADOOP-17897 for this javac warnings |
Member
Author
This can not be addressed as far as we are using TreeList of commons-collections 3 which does not support type parameters. We are already ignoring same warning for DistributedFileSystem. |
Member
Author
|
Following junit tests are not related to WebHDFS. I could not reproduce the test failure on my local.
|
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
Thanks for working on this. I'll review soon. |
jojochuang
reviewed
Oct 1, 2021
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java
Outdated
Show resolved
Hide resolved
...hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/JsonUtilClient.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
this is borrowed from DistributedFileSystem.
Member
Author
There was a problem hiding this comment.
I moved common logic to DFSUtilClient.
Contributor
There was a problem hiding this comment.
this is by and large copied from DistributedFileSystem.getSnapshotDiffReportInternal()
Member
Author
There was a problem hiding this comment.
I moved common logic to DFSUtilClient.
Contributor
There was a problem hiding this comment.
it would be nice to cache and remember this server does not support getSnapshotDiffReportListing.
Maybe as a follow-up enhancement.
Member
Author
There was a problem hiding this comment.
Let me do this in follow-up JIRA. I filed HDFS-16249.
|
💔 -1 overall
This message was automatically generated. |
jojochuang
approved these changes
Oct 29, 2021
Contributor
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
Hi @iwasakims There's a code conflict but i think we should get this in once the conflict is resolved. +1
… senario with multiple invocation of getSnapshotDiffReportListing in the test.
iwasakims
force-pushed
the
HDFS-16091-1
branch
from
56f4524 to
f28da90
Compare
Member
Author
|
Thanks, @jojochuang. I rebased this. |
|
💔 -1 overall
This message was automatically generated. |
Member
Author
|
The failure of TestRouterDistCpProcedure is intermittent one. I could not reproduce the failure on my local. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HDFS-16091
When there are millions of diffs between two snapshots, the old getSnapshotDiffReport() isn't scalable.
This PR adds GETSNAPSHOTDIFFLISTING op to NameNode WebHDFS API. WebHdfsFileSystem#getSnapshotDiffReport is fixed to leverage getSnapshotDiffReportListing in the same way as DistributedFileSystem#getSnapshotDiffReport.