HDFS-16137.Improve the comments related to FairCallQueue#queues.#3226
Merged
jojochuang merged 1 commit intoapache:trunkfrom Jul 28, 2021
Merged
HDFS-16137.Improve the comments related to FairCallQueue#queues.#3226jojochuang merged 1 commit intoapache:trunkfrom
jojochuang merged 1 commit intoapache:trunkfrom
Conversation
|
💔 -1 overall
This message was automatically generated. |
virajjasani
reviewed
Jul 25, 2021
Contributor
virajjasani
left a comment
virajjasani
left a comment
There was a problem hiding this comment.
Left minor nits, looks good otherwise
Comment on lines
61
to
64
Contributor
There was a problem hiding this comment.
nit: minor change and alignment of comment section:
/**
* Save the queue data of multiple priority strategies as list of blocking queues.
* Usually the number of queue data and priority strategies saved is the same.
*/
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/FairCallQueue.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@virajjasani , thanks for your comment. I will try to modify and submit some new codes later. |
jojochuang
reviewed
Jul 27, 2021
Contributor
There was a problem hiding this comment.
just a minor code style issue. We typically don't do wildcard imports in Hadoop codebase.
You can configure your IDE to not automatically collapse multiple imports into one wildcard import.
Other than that I am +1
Contributor
Author
|
@jojochuang , thanks for your comment. I will try to modify and submit some new codes later. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
kiran-maturi
pushed a commit
to kiran-maturi/hadoop
that referenced
this pull request
Nov 24, 2021
…che#3226) Co-authored-by: zhujianghua <zhujianghua@zhujianghuadeMacBook-Pro.local> Reviewed-by: Viraj Jasani <vjasani@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute