Skip to content

Addendum HADOOP-17770 WASB : Support disabling buffered reads in positional reads - Added the invalid SpotBugs warning to findbugs-exclude.xml #3223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
surendralilhore merged 2 commits into from
Jul 25, 2021
Merged

Addendum HADOOP-17770 WASB : Support disabling buffered reads in positional reads - Added the invalid SpotBugs warning to findbugs-exclude.xml #3223

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b380df
Addendum HADOOP-17770 WASB : Support disabling buffered reads in posi…
anoopsjohn Jul 22, 2021
d6304e0
Addendum HADOOP-17770 WASB : Support disabling buffered reads in posi…
anoopsjohn Jul 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions hadoop-tools/hadoop-azure/dev-support/findbugs-exclude.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,4 +83,17 @@
<Bug pattern="IS2_INCONSISTENT_SYNC" />
</Match>

<!-- This field is instance of BlockBlobInputStream and read(long, byte[], int, int)
calls it's Super class method when 'fs.azure.block.blob.buffered.pread.disable'
is configured false. Super class FSInputStream's implementation is having
proper synchronization.
When 'fs.azure.block.blob.buffered.pread.disable' is true, we want a lock free
implementation of blob read. Here we don't use any of the InputStream's
shared resource (buffer) and also don't change any cursor position etc.
So its safe to go with unsynchronized way of read. -->
<Match>
<Class name="org.apache.hadoop.fs.azure.NativeAzureFileSystem$NativeAzureFsInputStream" />
<Field name="in" />
<Bug pattern="IS2_INCONSISTENT_SYNC" />
</Match>
</FindBugsFilter>