HADOOP-17458. S3A to treat "SdkClientException: Data read has a different length than the expected" as EOFException#3040
Merged
steveloughran merged 4 commits intoapache:trunkfrom Jul 23, 2021
Conversation
added 3 commits
May 21, 2021 11:46
…ent length than the expected" as EOFException Some network exceptions would cause `SdkClientException` to fail with a `Data read has a different length than the expected` message. These should be recoverable. - Modifying `translateException` to recover from the above exception;
Added a test to check if the errors which we're translating by looking at the message are actually doing what we're expecting.
steveloughran
requested changes
Jun 11, 2021
Contributor
steveloughran
left a comment
steveloughran
left a comment
There was a problem hiding this comment.
code looks good.
we really some unit test for this, don't we? (we should have had one from the outset....)
Could you add one in org.apache.hadoop.fs.s3a.TestInvoker ? That'll stop us breaking this in future
Adding new unit tests to make sure that the new translatable exceptions are being translated and retried appropriately.
Contributor
Author
|
Sure thing 👍 ! Added them. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
@steveloughran let me know if the tests are ok, it's been a while for this PR and wanted to get it closed :D |
steveloughran
approved these changes
Jul 23, 2021
Contributor
steveloughran
left a comment
steveloughran
left a comment
There was a problem hiding this comment.
checkstyle is all line length. I'm Ok with that if it's not too wide and cutting down would actually hurt readability
steveloughran
changed the title
Contributor
|
(oh, two commits on trunk earlier: https://issues.apache.org/jira/browse/HADOOP-17813 , line length is now 100 chars!) |
asfgit
pushed a commit
that referenced
this pull request
Jul 23, 2021
…rent length than the expected" as EOFException (#3040) Some network exceptions can raise SdkClientException with message `Data read has a different length than the expected`. These should be recoverable. Contributed by Bogdan Stolojan Change-Id: Ia22fd77d90971e9e02b4f947398a4749eebe5909
kiran-maturi
pushed a commit
to kiran-maturi/hadoop
that referenced
this pull request
Nov 24, 2021
…rent length than the expected" as EOFException (apache#3040) Some network exceptions can raise SdkClientException with message `Data read has a different length than the expected`. These should be recoverable. Contributed by Bogdan Stolojan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HADOOP-17458
Some network exceptions would cause
SdkClientExceptionto fail with aData read has a different length than the expectedmessage. Theseshould be recoverable.
translateExceptionto recover from the above exception;Tested with
eu-west-1andmvn -Dparallel-tests -DtestsThreadCount=32 clean verify