HADOOP-17683. Update commons-io to 2.8.0 #2974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps commons-io from 2.5 to 2.7. Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
Contributor
|
(I triggered this thing. This is the first time this bot works successfully for the Hadoop project code. but it would be nice to update to 2.8.0 instead) |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
License binary also needs update. Once it is updated, full build will be triggered. |
aajisaka
requested changes
May 5, 2021
Member
aajisaka
left a comment
aajisaka
left a comment
There was a problem hiding this comment.
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2974/1/artifact/out/patch-shadedclient.txt
shaded client error is related.
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2974/src/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java:[612,14] exception java.io.IOException is never thrown in body of corresponding try statement
[INFO] 1 error
FileUtil.isSymlink does not throw IOException after IO-610.
aajisaka
reviewed
May 5, 2021
Member
aajisaka
left a comment
aajisaka
left a comment
There was a problem hiding this comment.
Add a commit to fix the compile error.
|
💔 -1 overall
This message was automatically generated. |
Member
|
TestFileUtils failure is related. Maybe it is caused by IO-629 and fixed by IO-684. Updating to commons-io 2.8.0 fixed this issue. |
|
💔 -1 overall
This message was automatically generated. |
jojochuang
approved these changes
May 11, 2021
Contributor
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
LGTM. We can deal with the deprecation warning for IOUtils.closeQuietly(OutputStream) later
Contributor
|
One change pending here, otherwise looks good. |
Member
|
Thank you @jojochuang and @virajjasani for your reviews. Updated the LICENSE-binary. I'll commit this. |
aajisaka
changed the title
aajisaka
deleted the
dependabot/maven/hadoop-project/commons-io-commons-io-2.7
branch
|
💔 -1 overall
This message was automatically generated. |
aajisaka
added a commit
that referenced
this pull request
May 12, 2021
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Akira Ajisaka <[email protected]> Signed-off-by: Wei-Chiu Chuang <[email protected]> (cherry picked from commit 29105ff)
kiran-maturi
pushed a commit
to kiran-maturi/hadoop
that referenced
this pull request
Nov 24, 2021
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Akira Ajisaka <[email protected]> Signed-off-by: Wei-Chiu Chuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: HADOOP-17683
Bumps commons-io from 2.5 to 2.7.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.