-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-11616. Remove workaround for Curator's ChildReaper requiring Guava 15+ #2973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jojochuang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like dead code to me. it's private scope so downstream applications aren't suppose to use it.
+1 pending Jenkins.
|
🎊 +1 overall
This message was automatically generated. |
|
Merged. Thank you @virajjasani and @jojochuang |
…uava 15+ (#2973) Reviewed-by: Wei-Chiu Chuang <[email protected]> Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit b93e448)
…uava 15+ (apache#2973) Reviewed-by: Wei-Chiu Chuang <[email protected]> Signed-off-by: Akira Ajisaka <[email protected]>
|
Hi @aajisaka, I saw this change went in after upgrading guava. We are removing these two classes as well and have an old guava but we try to avoid upgrading it in fear of breaking. Do you know is it mandatory? |
No description provided.