Skip to content

YARN-10756. Remove additional junit 4.11 dependency from javadoc. #2960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tasanuma merged 1 commit into from
May 6, 2021
Merged

YARN-10756. Remove additional junit 4.11 dependency from javadoc. #2960

tasanuma merged 1 commit into from
May 6, 2021

Conversation

@aajisaka
Copy link
Member

@aajisaka aajisaka commented Apr 27, 2021

JIRA: YARN-10756

@hadoop-yetus
Copy link

hadoop-yetus commented Apr 27, 2021

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 50s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 15m 47s Maven dependency ordering for branch
+1 💚 mvninstall 23m 11s trunk passed
+1 💚 compile 3m 50s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 compile 3m 5s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 mvnsite 1m 39s trunk passed
+1 💚 javadoc 1m 28s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 1m 21s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 shadedclient 66m 23s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for patch
+1 💚 mvninstall 1m 20s the patch passed
+1 💚 compile 3m 41s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javac 3m 42s the patch passed
+1 💚 compile 3m 4s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 javac 3m 4s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 1m 21s the patch passed
+1 💚 xml 0m 5s The patch has no ill-formed XML file.
+1 💚 javadoc 1m 9s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 1m 4s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 shadedclient 18m 34s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 1m 25s hadoop-yarn-server-timelineservice in the patch passed.
+1 💚 unit 0m 29s hadoop-yarn-server-timelineservice-hbase-client in the patch passed.
+1 💚 unit 15m 37s hadoop-yarn-server-timelineservice-hbase-tests in the patch passed.
+1 💚 unit 0m 41s hadoop-yarn-server-timelineservice-documentstore in the patch passed.
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
116m 6s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2960/1/artifact/out/Dockerfile
GITHUB PR #2960
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml
uname Linux dd1f80b4d2a3 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / ad9f853
Default Java Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2960/1/testReport/
Max. process+thread count 765 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase/hadoop-yarn-server-timelineservice-hbase-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2960/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (non-binding), nice cleanup

@BilwaST
Copy link
Contributor

BilwaST commented May 4, 2021

Thanks @aajisaka for changes. +1(Non-binding)

@aajisaka aajisaka requested a review from tasanuma May 6, 2021 06:13
tasanuma
tasanuma approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@tasanuma tasanuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tasanuma tasanuma merged commit 7cb7b8a into apache:trunk May 6, 2021
@tasanuma
Copy link
Member

tasanuma commented May 6, 2021

Merged. Thanks for fixing it, @aajisaka. Thanks for your reviews, @virajjasani and @BilwaST.

tasanuma pushed a commit that referenced this pull request May 6, 2021
@aajisaka @tasanuma
YARN-10756. Remove additional junit 4.11 dependency from javadoc. (#2960
2176552 
)

Reviewed-by: Viraj Jasani <[email protected]>
Reviewed-by: Bilwa S T <[email protected]>
Signed-off-by: Takanobu Asanuma <[email protected]>
(cherry picked from commit 7cb7b8a)
tasanuma pushed a commit that referenced this pull request May 6, 2021
@aajisaka @tasanuma
YARN-10756. Remove additional junit 4.11 dependency from javadoc. (#2960
a5bb211 
)

Reviewed-by: Viraj Jasani <[email protected]>
Reviewed-by: Bilwa S T <[email protected]>
Signed-off-by: Takanobu Asanuma <[email protected]>
(cherry picked from commit 7cb7b8a)
tasanuma pushed a commit that referenced this pull request May 6, 2021
@aajisaka @tasanuma
YARN-10756. Remove additional junit 4.11 dependency from javadoc. (#2960
badb6b3 
)

Reviewed-by: Viraj Jasani <[email protected]>
Reviewed-by: Bilwa S T <[email protected]>
Signed-off-by: Takanobu Asanuma <[email protected]>
(cherry picked from commit 7cb7b8a)
@aajisaka
Copy link
Member Author

aajisaka commented May 6, 2021

Thank you @virajjasani, @BilwaST, and @tasanuma

@aajisaka aajisaka deleted the YARN-10756 branch May 6, 2021 22:53
kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021
@aajisaka
YARN-10756. Remove additional junit 4.11 dependency from javadoc. (ap…
1890c8b 
…ache#2960)

Reviewed-by: Viraj Jasani <[email protected]>
Reviewed-by: Bilwa S T <[email protected]>
Signed-off-by: Takanobu Asanuma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tasanuma tasanuma tasanuma approved these changes

+1 more reviewer

@virajjasani virajjasani virajjasani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aajisaka @hadoop-yetus @BilwaST @tasanuma @virajjasani